Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Parser]: GraphQL Express #14

Closed
jmcdo29 opened this issue Mar 28, 2020 · 0 comments
Closed

[Parser]: GraphQL Express #14

jmcdo29 opened this issue Mar 28, 2020 · 0 comments
Assignees
@jmcdo29
Labels
enhancement 🐺 A new feature to be implemented graphql 🕸️ A problem with the graphql parser Has PR This issue has a PR related to it, or is in a branch in development Ready This issue has been taken care of and is waiting to be merged
Milestone
@ogma/namespace

Comments

@jmcdo29
Copy link
Owner

jmcdo29 commented Mar 28, 2020

Now that the core functionality has been re-written, it would be great to actually include GraphQL in the request logging.

Looking for: package under the name @ogma/platform-graphql that exports a class GqlInterceptorParser that extends AbstractInterceptorService from the @ogma/nestjs-module package.

The output should be in the same format as the ExpressInterceptorParser.
@jmcdo29 jmcdo29 added help wanted 🆘 Extra attention is needed good first issue 👍 Good for newcomers enhancement 🐺 A new feature to be implemented graphql 🕸️ A problem with the graphql parser labels Mar 28, 2020
@jmcdo29 jmcdo29 added this to the @ogma/namespace milestone Mar 28, 2020
@jmcdo29 jmcdo29 changed the title [Parser]: GraphQL Express Parser [Parser]: GraphQL Express Mar 28, 2020
jmcdo29 added a commit that referenced this issue Apr 11, 2020
@jmcdo29
feat(gql): implements gql parser for express
df3cd9c 
The GqlParser now is working for express. There are updates to the main module packages to handle
whenever subscriptions come in, as there is not enough information in them to properly add them to
the request logging. This may change in the future.

fix #14
@jmcdo29 jmcdo29 mentioned this issue Apr 11, 2020
Merged
jmcdo29 added a commit that referenced this issue Apr 13, 2020
@jmcdo29
feat(gql): implements gql parser for express
9290504 
The GqlParser now is working for express. There are updates to the main module packages to handle
whenever subscriptions come in, as there is not enough information in them to properly add them to
the request logging. This may change in the future.

fix #14
@jmcdo29 jmcdo29 self-assigned this Apr 17, 2020
@jmcdo29 jmcdo29 added Ready This issue has been taken care of and is waiting to be merged Has PR This issue has a PR related to it, or is in a branch in development and removed good first issue 👍 Good for newcomers help wanted 🆘 Extra attention is needed labels Apr 17, 2020
@jmcdo29 jmcdo29 closed this as completed Apr 21, 2020
jmcdo29 added a commit that referenced this issue Jun 20, 2021
@jmcdo29
feat(gql): implements gql parser for express
365d55a 
The GqlParser now is working for express. There are updates to the main module packages to handle
whenever subscriptions come in, as there is not enough information in them to properly add them to
the request logging. This may change in the future.

fix #14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmcdo29 jmcdo29

Labels
enhancement 🐺 A new feature to be implemented graphql 🕸️ A problem with the graphql parser Has PR This issue has a PR related to it, or is in a branch in development Ready This issue has been taken care of and is waiting to be merged
Projects
None yet
Milestone
@ogma/namespace
Development

No branches or pull requests
1 participant
@jmcdo29