Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Parser]: TCP #23

Closed
jmcdo29 opened this issue Mar 28, 2020 · 0 comments
Closed

[Parser]: TCP #23

jmcdo29 opened this issue Mar 28, 2020 · 0 comments
Assignees
@jmcdo29
Labels
enhancement 🐺 A new feature to be implemented Has PR This issue has a PR related to it, or is in a branch in development Ready This issue has been taken care of and is waiting to be merged tcp A problem with the TCP parser
Milestone
@ogma/namespace

Comments

@jmcdo29
Copy link
Owner

jmcdo29 commented Mar 28, 2020

Now that the core functionality has been re-written, it would be great to actually include TCP in the request logging.

Looking for: package under the name @ogma/platform-tcp that exports a class TcpInterceptorParser that extends AbstractInterceptorService from the @ogma/nestjs-module package.

The output of this is still to be determined. Some values may need to be hard-coded
@jmcdo29 jmcdo29 added help wanted 🆘 Extra attention is needed good first issue 👍 Good for newcomers enhancement 🐺 A new feature to be implemented tcp A problem with the TCP parser labels Mar 28, 2020
@jmcdo29 jmcdo29 added this to the @ogma/namespace milestone Mar 28, 2020
jmcdo29 added a commit that referenced this issue Apr 4, 2020
@jmcdo29
feat(tcp): implements first draft of tcp parser
771c577 
The TCP parser pulls information from the socket connection and has a hard codeded method of TCP,
though this may change to protocol instead of method. Protocol currently takes from the remote
connections family (an IP version). The call point must be stringified in the case of using a json
as the message pattern (as the NestJS docs show). Integration has also been built for this, using
concurrently to run the client and server servers.

fix #23
jmcdo29 added a commit that referenced this issue Apr 6, 2020
@jmcdo29
feat(tcp): implements first draft of tcp parser
189b5a4 
The TCP parser pulls information from the socket connection and has a hard codeded method of TCP,
though this may change to protocol instead of method. Protocol currently takes from the remote
connections family (an IP version). The call point must be stringified in the case of using a json
as the message pattern (as the NestJS docs show). Integration has also been built for this, using
concurrently to run the client and server servers.

fix #23
@jmcdo29 jmcdo29 mentioned this issue Apr 6, 2020
Merged
jmcdo29 added a commit that referenced this issue Apr 6, 2020
@jmcdo29
feat(tcp): implements first draft of tcp parser
bf0eb6b 
The TCP parser pulls information from the socket connection and has a hard codeded method of TCP,
though this may change to protocol instead of method. Protocol currently takes from the remote
connections family (an IP version). The call point must be stringified in the case of using a json
as the message pattern (as the NestJS docs show). Integration has also been built for this, using
concurrently to run the client and server servers.

fix #23
@jmcdo29 jmcdo29 added Has PR This issue has a PR related to it, or is in a branch in development Ready This issue has been taken care of and is waiting to be merged and removed good first issue 👍 Good for newcomers help wanted 🆘 Extra attention is needed labels Apr 6, 2020
@jmcdo29 jmcdo29 closed this as completed Apr 21, 2020
jmcdo29 added a commit that referenced this issue Jun 20, 2021
@jmcdo29
feat(tcp): implements first draft of tcp parser
3a8acc5 
The TCP parser pulls information from the socket connection and has a hard codeded method of TCP,
though this may change to protocol instead of method. Protocol currently takes from the remote
connections family (an IP version). The call point must be stringified in the case of using a json
as the message pattern (as the NestJS docs show). Integration has also been built for this, using
concurrently to run the client and server servers.

fix #23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmcdo29 jmcdo29

Labels
enhancement 🐺 A new feature to be implemented Has PR This issue has a PR related to it, or is in a branch in development Ready This issue has been taken care of and is waiting to be merged tcp A problem with the TCP parser
Projects
None yet
Milestone
@ogma/namespace
Development

No branches or pull requests
1 participant
@jmcdo29