-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pi-Apps installer broken #201
Comments
Attached are the two logfiles we received. |
I don't know when was the moment in the time PiKISS depended on Pi-Apps. I don't want to be rude, but I had to add some code to make it compatible with YOUR software, but is not my business. You always can remove my software from Pi-Apps. So, I'm going to fix for Pi-Apps this time, but If It's broken again in the future, I'm afraid you must come here again and notify me, and maybe I'll see what I can do. |
I would clarify that for both times something broke, it was due to a change you made that broke noninteractive installation. Ideally there would not need to be any specific pi-apps workarounds. For example, you would have encountered the same two problems if you tried packaging pikiss into a deb package, as in some cases those can be noninteractive.
I could, but before you start suggesting such things, please be reminded that Pi-Apps has brought in 27,393 users to your project. source |
I repeat I am not going to test that the changes I make will work in Pi-Apps. You are free to do whatever you want in consequence. Maybe I don't sound fair towards users who bounce my software through you, and I feel sorry for them, but I will not tolerate any threats. |
due to upstream breakage for the third time recently jmcerrejon/PiKISS#201
Pi-Apps runs this command to install piKiss:
Your commit here, "👌 IMPROVE: run piKiss.sh when install it" broke the installer.
Now when installing PiKISS from Pi-Apps, users are greeted with the pikiss interface. This is bad because installs should be automatic and noninteractive.
Also, your internet connection check is failing on some systems. We have had two error reports sent in where pikiss installs fine but once it is run, your
check_internet_available
function incorrectly detects a lost internet connection.This issue is requesting three changes:
The text was updated successfully, but these errors were encountered: