Fix for handling readonly images on Windows.

Issue #352

xlsxwriter/packager.py

@@ -7,6 +7,7 @@
 
 # Standard packages.
 import os
+import stat
 import tempfile
 from shutil import copy
 
@@ -584,6 +585,12 @@ def _add_image_files(self):
                 else:
                     copy(filename, os_filename)
 
+                    # Allow copies of Windows readonly images to be deleted.
+                    try:
+                        os.chmod(os_filename,
+                                 os.stat(os_filename).st_mode | stat.S_IWRITE)
+                    except:
+                        pass
             else:
                 # For in-memory mode we read the image into a stream.
                 if image_data:

xlsxwriter/test/comparison/test_image34.py

@@ -0,0 +1,42 @@
+###############################################################################
+#
+# Tests for XlsxWriter.
+#
+# Copyright (c), 2013-2016, John McNamara, jmcnamara@cpan.org
+#
+
+from ..excel_comparsion_test import ExcelComparisonTest
+from ...workbook import Workbook
+
+
+class TestCompareXLSXFiles(ExcelComparisonTest):
+    """
+    Test file created by XlsxWriter against a file created by Excel.
+
+    """
+
+    def setUp(self):
+        self.maxDiff = None
+
+        filename = 'image34.xlsx'
+
+        test_dir = 'xlsxwriter/test/comparison/'
+        self.image_dir = test_dir + 'images/'
+        self.got_filename = test_dir + '_test_' + filename
+        self.exp_filename = test_dir + 'xlsx_files/' + filename
+
+        self.ignore_files = []
+        self.ignore_elements = {}
+
+    def test_create_file(self):
+        """Test the creation of a simple XlsxWriter file with image(s)."""
+
+        workbook = Workbook(self.got_filename)
+
+        worksheet = workbook.add_worksheet()
+
+        worksheet.insert_image('E9', self.image_dir + 'red_readonly.png')
+
+        workbook.close()
+
+        self.assertExcelEqual()