Feature/localforage #146
Closed
Feature/localforage #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW your contributions.md says to merge to develop, but that branch doesn't exist. |
|
Changes Unknown when pulling 17710a1 on toadkicker:feature/localforage into * on jmdobry:master*. |
toadkicker
force-pushed
the
feature/localforage
branch
from
d6e7f9c
to
91bf9fa
Compare
|
Changes Unknown when pulling 91bf9fa on toadkicker:feature/localforage into * on jmdobry:master*. |
|
+1 |
|
I'm sorry, but this will not work. The API for angular-cache is synchronous, while localforage is asynchronous, returning promises or requiring callbacks. Angular-cache expects For more advanced storage options, take a look at js-data |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added localforage support to angular cache