Add numeric as a comparable type

jmespath · Nov 21, 2022 · c27c82d · c27c82d
1 parent 57d77ea
commit c27c82d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,8 @@
+Unreleased Changes
+------------------
+
+* Issue - Allow comparison of Numeric types (includes Float).
+
 1.6.1 (2022-03-07)
 ------------------
 

diff --git a/lib/jmespath/nodes/condition.rb b/lib/jmespath/nodes/condition.rb
@@ -28,7 +28,7 @@ def optimize
 
     class ComparatorCondition < Node
       COMPARATOR_TO_CONDITION = {}
-      COMPARABLE_TYPES = [Integer, Float, String].freeze
+      COMPARABLE_TYPES = [Numeric, String].freeze
 
       def initialize(left, right, child)
         @left = left
@@ -43,8 +43,8 @@ def visit(_value)
       private
 
       def comparable?(left_value, right_value)
-        if COMPARABLE_TYPES.include?(left_value.class) && COMPARABLE_TYPES.include?(right_value.class)
-          (left_value.class == right_value.class) || (left_value.is_a?(Numeric) && right_value.is_a?(Numeric))
+        COMPARABLE_TYPES.any? do |type|
+          left_value.is_a?(type) && right_value.is_a?(type)
         end
       end
     end