Account for using {first: 0} for immediate execution of RepeatJobs #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to v3, you could specify the option {first_in: 0} to have the scheduler fire the job immediately. This does not work anymore since only the symbols :now or :immediately are accounted for when setting @first_at to be slightly after Time.now (Time.now + 0.003).
Currently, @first_at will be set to Time.now if the options specify 0 and the scheduler won't fire the job until Time.now + frequency.
The Dashing dashboard framework (http://shopify.github.io/dashing/) is forced to stay on v2.0.24 due to a large amount of 3rd party widgets using {first_in: 0} to specify immediate execution of the scheduled job (https://github.com/Shopify/dashing/wiki/Additional-Widgets)
|
OK, I will bring your patch in, add specs for it and rework it. Thanks! |
jmettraux
added a commit
that referenced
this pull request
Nov 17, 2015
account for using {first: 0} for immediate execution of RepeatJobs
JonMcPherson
referenced
this pull request
in Shopify/dashing
Nov 17, 2015
…rom using the rewritten RS (3.0). So for now let's use this version until Dashing 2.0 comes out.
jmettraux
added a commit
that referenced
this pull request
Nov 17, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to v3, you could specify the option {first_in: 0} to have the scheduler fire the job immediately. This does not work anymore since only the symbols :now or :immediately are accounted for when setting @first_at to be slightly after Time.now (Time.now + 0.003).
Currently, @first_at will be set to Time.now if the options specify 0 and the scheduler won't fire the job until Time.now + frequency.
The Dashing dashboard framework is forced to stay on v2.0.24 due to a large amount of 3rd party widgets using {first_in: 0} to specify immediate execution of the scheduled job