Use .nil? instead of == nil

[paulodelgado]

I was having issues with rufus + ActiveSupport(3.2.22)

When checking for @started_at == nil my system tried to use ActiveSupport's "compare_with_coercion" which ended up failing trying to run .to_datetime on null.

Not sure if I'm fixing this in the right place but I thought I'd give it a try.

[jmettraux]

Hello,

thanks for the report.

May I see the error and its backtrace?

Thanks in advance.

[paulodelgado]

This was the error on AS 3.2.12

rake aborted!
NoMethodError: undefined method `to_datetime' for nil:NilClass
/home/username/.rvm/gems/ruby-2.3.1@project/gems/activesupport-3.2.12/lib/active_support/core_ext/date_time/calculations.rb:141:in `<=>'
/home/username/.rvm/gems/ruby-2.3.1@project/gems/activesupport-3.2.12/lib/active_support/core_ext/time/calculations.rb:346:in `compare_with_coercion'
/home/username/.rvm/gems/ruby-2.3.1@project/gems/rufus-scheduler-3.2.1/lib/rufus/scheduler.rb:612:in `=='
/home/username/.rvm/gems/ruby-2.3.1@project/gems/rufus-scheduler-3.2.1/lib/rufus/scheduler.rb:612:in `do_schedule'
/home/username/.rvm/gems/ruby-2.3.1@project/gems/rufus-scheduler-3.2.1/lib/rufus/scheduler.rb:225:in `every'
/home/username/.rvm/gems/ruby-2.3.1@project/gems/resque-scheduler-4.2.0/lib/resque/scheduler.rb:142:in `block in load_schedule_job'
/home/username/.rvm/gems/ruby-2.3.1@project/gems/resque-scheduler-4.2.0/lib/resque/scheduler.rb:137:in `each'
/home/username/.rvm/gems/ruby-2.3.1@project/gems/resque-scheduler-4.2.0/lib/resque/scheduler.rb:137:in `load_schedule_job'
/home/username/.rvm/gems/ruby-2.3.1@project/gems/resque-scheduler-4.2.0/lib/resque/scheduler.rb:99:in `block in load_schedule!'
/home/username/.rvm/gems/ruby-2.3.1@project/gems/resque-scheduler-4.2.0/lib/resque/scheduler.rb:98:in `each'
/home/username/.rvm/gems/ruby-2.3.1@project/gems/resque-scheduler-4.2.0/lib/resque/scheduler.rb:98:in `load_schedule!'
/home/username/.rvm/gems/ruby-2.3.1@project/gems/resque-scheduler-4.2.0/lib/resque/scheduler.rb:52:in `run'
/home/username/.rvm/gems/ruby-2.3.1@project/gems/resque-scheduler-4.2.0/lib/resque/scheduler/cli.rb:117:in `run_forever'
/home/username/.rvm/gems/ruby-2.3.1@project/gems/resque-scheduler-4.2.0/lib/resque/scheduler/tasks.rb:18:in `block (2 levels) in <top (required)>'
/home/username/.rvm/gems/ruby-2.3.1@project/bin/ruby_executable_hooks:15:in `eval'
/home/username/.rvm/gems/ruby-2.3.1@project/bin/ruby_executable_hooks:15:in `<main>'
Tasks: TOP => resque:scheduler

And this is the error on AS 3.2.22

NameError: uninitialized constant DateTime::Infinity
/home/username/.rvm/gems/ruby-2.3.1@project/gems/activesupport-3.2.22/lib/active_support/core_ext/date_time/calculations.rb:141:in `<=>'
/home/username/.rvm/gems/ruby-2.3.1@project/gems/activesupport-3.2.22/lib/active_support/core_ext/time/calculations.rb:359:in `compare_with_coercion'
/home/username/.rvm/gems/ruby-2.3.1@project/gems/rufus-scheduler-3.2.1/lib/rufus/scheduler.rb:612:in `=='
/home/username/.rvm/gems/ruby-2.3.1@project/gems/rufus-scheduler-3.2.1/lib/rufus/scheduler.rb:612:in `do_schedule'
/home/username/.rvm/gems/ruby-2.3.1@project/gems/rufus-scheduler-3.2.1/lib/rufus/scheduler.rb:225:in `every'
/home/username/.rvm/gems/ruby-2.3.1@project/gems/resque-scheduler-4.2.0/lib/resque/scheduler.rb:142:in `block in load_schedule_job'
/home/username/.rvm/gems/ruby-2.3.1@project/gems/resque-scheduler-4.2.0/lib/resque/scheduler.rb:137:in `each'
/home/username/.rvm/gems/ruby-2.3.1@project/gems/resque-scheduler-4.2.0/lib/resque/scheduler.rb:137:in `load_schedule_job'
/home/username/.rvm/gems/ruby-2.3.1@project/gems/resque-scheduler-4.2.0/lib/resque/scheduler.rb:99:in `block in load_schedule!'
/home/username/.rvm/gems/ruby-2.3.1@project/gems/resque-scheduler-4.2.0/lib/resque/scheduler.rb:98:in `each'
/home/username/.rvm/gems/ruby-2.3.1@project/gems/resque-scheduler-4.2.0/lib/resque/scheduler.rb:98:in `load_schedule!'
/home/username/.rvm/gems/ruby-2.3.1@project/gems/resque-scheduler-4.2.0/lib/resque/scheduler.rb:52:in `run'
/home/username/.rvm/gems/ruby-2.3.1@project/gems/resque-scheduler-4.2.0/lib/resque/scheduler/cli.rb:117:in `run_forever'
/home/username/.rvm/gems/ruby-2.3.1@project/gems/resque-scheduler-4.2.0/lib/resque/scheduler/tasks.rb:18:in `block (2 levels) in <top (required)>'
/home/username/.rvm/gems/ruby-2.3.1@project/gems/rake-11.2.2/exe/rake:27:in `<top (required)>'
/home/username/.rvm/gems/ruby-2.3.1@project/bin/ruby_executable_hooks:15:in `eval'
/home/username/.rvm/gems/ruby-2.3.1@project/bin/ruby_executable_hooks:15:in `<main>'

[jmettraux]

Thanks a lot!

[jmettraux]

(somehow I can't stop thinking there is something very wrong with ActiveSupport here, they're breaking Ruby)

[paulodelgado]

Its weird, yes. I wonder if @tenderlove has ideas here. Can I tag him here?

[jmettraux]

You just did. I'm a bit old, I'd rather first build some evidence then report to the maintainers of ActiveSupport, if there is anything to report, rather than ping one maintainer out of the blue with an issue on a library not linked to ActiveSupport.

[jmettraux]

Investigating in https://github.com/jmettraux/as_equal_equal ...

[jmettraux]

Hello @paulodelgado,

I've built https://github.com/jmettraux/as_equal_equal to try and reproduce your issue, but without success. Please try it with your 2.3.1 Ruby (I limited myself to a 2.1.3 I have lying around). If you can build on that as_equal_equal and reproduce the issue, that's worth reporting somewhere.

Best regards.

[paulodelgado]

Interesting, I'm also unable to reproduce it. I got some work to do so i'll try again later. Thanks for taking a look at it!