Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception / cancel build instead of adding failureComment #647

Open
jschneider opened this issue Nov 26, 2022 · 2 comments
Open

Throw exception / cancel build instead of adding failureComment #647

jschneider opened this issue Nov 26, 2022 · 2 comments

Comments

@jschneider
Copy link

The current behavior if a repository is unreachable:

  • adding a comment into the version.properties:

e.g.

failed to check repo https://plugins.gradle.org/m2/ Cause: network or server issue (class javax.net.ssl.SSLHandshakeException PKIX path validation failed: java.security.cert.CertPathValidatorException: validity check failed)

But the build finishes successfully.

I would prefer refreshVersions to throw an exception and fail the build.

Reasoning:
I have automated refreshVersions in the CI pipeline. And those comments could end up being merged into "main".

@LouisCAD
Copy link
Member

That was the initial behavior, but we changed it because it was a pain when one of the repos wasn't working.

We won't change it back, but we might consider adding an option for your use case. Any idea on the naming and configuration location?

@jschneider
Copy link
Author

I started implementing this feature. But didn't find a good way to get the configuration into Write versions candidates using latest most stable version and get it

I didn't want to add a parameter - but probably it is necessary...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants