Skip to content

Commit

Permalink
Updated to Playwright 1.34.3
Browse files Browse the repository at this point in the history
Runs well locally, but there is a bug with this version that pops up when running everything in the containerized environment.

Refer to: microsoft/playwright#23314
  • Loading branch information
jmflaherty committed May 27, 2023
1 parent 860e68a commit 5413eb4
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 172 deletions.
5 changes: 3 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
FROM mcr.microsoft.com/playwright:v1.34.3-focal
FROM mcr.microsoft.com/playwright:v1.34.3-jammy

WORKDIR /app/

ENV PATH /app/node_modules/.bin:$PATH
ENV CI = true

RUN corepack enable
RUN yarn global add npm

COPY package.json /app/
RUN yarn install
RUN yarn install --production && yarn cache clean

COPY . /app/

Expand Down
186 changes: 19 additions & 167 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"docker:build": "docker build -t medusajs-playwright .",
"docker:stop": "docker stop medusajs-playwright",
"docker:remove": "docker rm medusajs-playwright",
"docker:system:prune": "docker system prune --force",
"lint": "eslint --ext .js,.ts .",
"lint:fix": "eslint --ext .js,.ts . --fix"
},
Expand All @@ -38,18 +39,15 @@
"@types/node": "^20.2.5",
"@typescript-eslint/eslint-plugin": "^5.59.7",
"@typescript-eslint/parser": "^5.59.7",
"axios": "^1.4.0",
"builder-pattern": "^2.2.0",
"eslint": "^8.41.0",
"eslint-config-prettier": "^8.8.0",
"eslint-plugin-prettier": "^4.2.1",
"playwright": "^1.34.3",
"prettier": "^2.8.8",
"ts-node": "^10.9.1",
"typescript": "^5.0.4"
},
"dependencies": {
"global": "^4.4.0",
"yarn": "^1.22.19"
}
}

0 comments on commit 5413eb4

Please sign in to comment.