Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for btn styles on button elements #17

Merged
merged 1 commit into from Feb 28, 2017

Conversation

timojarv
Copy link
Contributor

Currently elements with "siimple-btn" styles have ugly default borders on them. This pull request removes borders from buttons so that the "siimple-btn" styles can be used with regular elements.

@jmjuanes
Copy link
Owner

Hello @timojarv !

First, thanks for your PR! The changes on scss/btn/_btn.scss are perfect and necessary, but there are some problems on the others files:

  • The file yarn.lock is necessary?
  • All the modifications on the dist/ folder are irrelevant, because they will be overwritten when I publish the new version. The only important changes are in the scss/ folder.

Please, can you do a new PR with only the changes on scss/btn/_btn.scss?

@timojarv
Copy link
Contributor Author

timojarv commented Feb 28, 2017 via email

@jmjuanes jmjuanes merged commit a0040e7 into jmjuanes:master Feb 28, 2017
@jmjuanes
Copy link
Owner

Ok, I will remove manually the extra css files in dist. Thank you! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants