Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SymbolMorphs match height of input in blocks. #2952

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

opencoca
Copy link

This makes blocks containing BlockSymbolMorph parts match the height of blocks with input(s) .

TODO increase height of blocks containing only BlockLabelMorphs to match.

@jmoenig
Copy link
Owner

jmoenig commented Jan 1, 2022

can you elaborate a little bit what this PR addresses, perhaps with a screenshot before and after? seems like the only change is an adjustment factor....

@opencoca
Copy link
Author

opencoca commented Jan 3, 2022

Yes it's a very minor tweak. It standardizes the height of blocks.

Please disregard the silly grey block name in the gif it's unimportant.

Block_morph_height

As you can see in the animation this pull tweaks things so that the blocks with SymbolMorphs and the blocks with inputs are of the same height. I'm still trying to decide how to best standardize the size of blocks containing only BlockLabelMorphs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants