Mqtt for v10 (3rd try) #3377
Merged
Mqtt for v10 (3rd try) #3377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update mqtt.xml and mqttExtension.js to use lovely new variadic options that are inV10 Includes Maximum QoS for subscribe block by Xavier Pi as well
Bugfixes for mqtt.xml
To use V10 variadic features 2nd bug fix
Added changes from Xavier Pi 16thJul2024
Re-add sanitise mask to connect block
Yet another correction
|
Hi Simon, I'm seeing a lot of activity in this pull request. Do you want some more time before I actually pull it? |
|
No :)
Its's good to go with both me and Xavier
[image: image.png]
regards
Simon
…On Tue, 16 Jul 2024 at 16:03, Jens Mönig ***@***.***> wrote:
Hi Simon, I'm seeing a lot of activity in this pull request. Do you want
some more time before I actually pull it?
—
Reply to this email directly, view it on GitHub
<#3377 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAR7RNBPKXS4SVTOVDQZIMTZMUY5TAVCNFSM6AAAAABK2OESUWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZRGE2DMMZQGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Excellent, thanks! Will pull into rc2 tomorrow, then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update MQTT extension using V10 new variadic features
Also, from Xavier Pi - add in QoS for subscribe