Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No support for non-integer "auto-next" primary keys #20

Open
jmoiron opened this issue Aug 17, 2014 · 2 comments
Open

No support for non-integer "auto-next" primary keys #20

jmoiron opened this issue Aug 17, 2014 · 2 comments

Comments

@jmoiron
Copy link
Owner

jmoiron commented Aug 17, 2014

From a bug report in IRC. With a pg table defined like this:

id uuid primary key default uuid_generate_v4()

The Dialect InsertAutoIncr(...) (int64, error) obviously fails scanning the returned id into an int64. Gorp has added new APIs for this (in order to prevent breaking existing code), will follow suit with modl.
jmoiron added a commit that referenced this issue Sep 6, 2014
@jmoiron
add InsertAutoIncrAny to the interface. This is a compile time breaka…
c028a25 
…ge for custom dialects, but doesn't break or impact any other code. This is in preparation for #20
@jmoiron
Copy link
Owner Author

jmoiron commented Sep 6, 2014

The first part of this is sorta complete. What has to happen now is the new interface must be use in place of the old one, before doing this I want to get the sqlx reflectx mapper integrated with modl in order to be able to store AutoIncrField names and be able to quickly get them as scan targets. This is going to be necessary in the long run anyway and should clean up a lot of modl code.

@ferhatelmas
Copy link

Could you please give a status update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmoiron @ferhatelmas