fix/90 prevent locking user funds in _withdrawFromVault #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…during-deposit 3.1 yearn re entrancy attack during deposit
asselstine
reviewed
Jul 5, 2021
| @@ -188,7 +191,7 @@ contract YearnV2YieldSource is IYieldSource, ERC20Upgradeable, OwnableUpgradeabl | |||
| } | |||
| uint256 currentBalance = token.balanceOf(address(this)); | |||
|
|
|||
| return previousBalance.sub(currentBalance); | |||
| return currentBalance > previousBalance ? currentBalance.sub(previousBalance) : 0; | |||
There was a problem hiding this comment.
Is this from the other PR? Conditional is a no-op
asselstine
approved these changes
Jul 5, 2021
asselstine
requested changes
Jul 5, 2021
reduce SLOAD calls in _withdrawFromVault
gas optimization
reduce SLOAD calls in _depositInVault
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code-423n4/2021-06-pooltogether-findings#90