Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get all bookings for an amenity with an optional time range #114

Open
jmprathab opened this issue Aug 8, 2020 · 6 comments
Open

Get all bookings for an amenity with an optional time range #114

jmprathab opened this issue Aug 8, 2020 · 6 comments
Assignees
@bayotheman
Labels
enhancement New feature or request good first issue Good for newcomers up-for-grabs up-for-grabs

Comments

@jmprathab
Copy link
Owner

jmprathab commented Aug 8, 2020 •
edited
Loading

⚠️ Is your feature request related to a problem? Please describe

  • Get all bookings for an amenity with an optional time range

💡 Describe the solution you'd like

  • GET /amenities/{amenityId}/bookings?start='01-01-2020'&end='01-02-2020'
  • The API should support pagination
  • Code pointers for pagination - CommunityService.java::listAll
  • Update postman collection

Task Relationship

Subtask of: #94
@jmprathab jmprathab added enhancement New feature or request good first issue Good for newcomers up-for-grabs up-for-grabs labels Aug 8, 2020
@jmprathab jmprathab mentioned this issue Aug 8, 2020
Open
4 tasks
@DDmit04
Copy link
Contributor

DDmit04 commented Aug 8, 2020

Is pagination needed for result bookings list?

@jmprathab
Copy link
Owner Author

Is pagination needed for result bookings list?

Yes. It is required. I will modify the comments to include that. Thanks!

@nlaert
Copy link

nlaert commented Sep 25, 2020

Hello, I will take this ticket for starting, is that ok? :)

@jmprathab
Copy link
Owner Author

@nlaert Sure. I have assigned it to you.

nlaert pushed a commit to nlaert/MyHome that referenced this issue Oct 9, 2020
Issue jmprathab#114: Get all bookings of an amenity
3c6fa91
@nlaert nlaert mentioned this issue Oct 9, 2020
Closed
6 tasks
nlaert pushed a commit to nlaert/MyHome that referenced this issue Oct 11, 2020
Issue jmprathab#114: Resolve Conflicts + Adding more tests + PR review
1305e01
nlaert pushed a commit to nlaert/MyHome that referenced this issue Oct 15, 2020
Issue jmprathab#114: Get all bookings of an amenity
e18ba53
nlaert pushed a commit to nlaert/MyHome that referenced this issue Oct 15, 2020
Issue jmprathab#114: Resolve Conflicts + Adding more tests + PR review
c784341
nlaert pushed a commit to nlaert/MyHome that referenced this issue Oct 15, 2020
Issue jmprathab#114: Resolve Conflicts + small refactor on tests
0d0793c
nlaert pushed a commit to nlaert/MyHome that referenced this issue Oct 15, 2020
Issue jmprathab#114: Return 404 if amenityId does not exist
8e721f3
nlaert pushed a commit to nlaert/MyHome that referenced this issue Oct 16, 2020
Issue jmprathab#114: Resolve Conflicts
7fcca24
nlaert pushed a commit to nlaert/MyHome that referenced this issue Oct 16, 2020
Issue jmprathab#114: Replace isEmpty by !isPresent due to gradle buil…
7682c9c 
…d failure on github
nlaert pushed a commit to nlaert/MyHome that referenced this issue Oct 16, 2020
Issue jmprathab#114: forgot to fix the tests also
3f0bb0f
@rmgrimm rmgrimm mentioned this issue Oct 31, 2020
Closed
6 tasks
@nlaert nlaert mentioned this issue Nov 1, 2020
Closed
6 tasks
@bayotheman
Copy link

Hi @jmprathab @mslowiak , can I take on this task?

bayotheman added a commit to bayotheman/MyHome that referenced this issue Oct 19, 2022
@bayotheman
Issue jmprathab#114: Get all bookings for an amenity with an optional…
133d8da 
… time range
bayotheman added a commit to bayotheman/MyHome that referenced this issue Oct 19, 2022
@bayotheman
Issue jmprathab#114: Get all bookings for an amenity with an optional…
0ae015f 
… time range
@bayotheman
Copy link

hi @mslowiak I have made the PR to this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bayotheman bayotheman

Labels
enhancement New feature or request good first issue Good for newcomers up-for-grabs up-for-grabs
Projects
None yet
Milestone
No milestone
4 participants
@nlaert @jmprathab @bayotheman @DDmit04