Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paging information to /communities/{communityId}/admins/{adminId}/payments #222

Closed
mslowiak opened this issue Feb 17, 2021 · 1 comment · Fixed by #223
Closed

Add paging information to /communities/{communityId}/admins/{adminId}/payments #222

mslowiak opened this issue Feb 17, 2021 · 1 comment · Fixed by #223
Assignees
Labels
enhancement New feature or request high-priority

Comments

@mslowiak
Copy link
Collaborator

We need to support pagination results for the frontend pagination feature.

Things to be done:

  • Define PageInfo class
  • Apply that class to ListAdminPaymentsResponse as another property called pageInfo
  • Update api.yaml schema
  • Update and fix tests

CC: @Tobi406

@mslowiak
Copy link
Collaborator Author

mslowiak commented Feb 17, 2021

A new model for a response, in that case, would include the PageInfo object @Tobi406.

Example:

{
  "payments": [
    {
      "adminId": "string",
      "paymentId": "string",
      "charge": 0,
      "dueDate": "string"
    }
  ],
  "pageInfo": {
    "currentPage": 0,
    "pageLimit": 0,
    "totalPages": 0,
    "totalElements": 0
  }
}

mslowiak added a commit that referenced this issue Feb 18, 2021
…ion-results-for-payments

Issue #222: Add pagination results for payments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high-priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant