Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shuffle starts on first song #61

Closed
drazil100 opened this issue Jul 11, 2021 · 23 comments · Fixed by #442
Closed

Shuffle starts on first song #61

drazil100 opened this issue Jul 11, 2021 · 23 comments · Fixed by #442

Comments

@drazil100
Copy link

When opening a playlist or album and pressing the big shuffle button at the top it always starts by playing the first song on the list. It would be great if it started on a random song.

@jmshrv
Copy link
Owner

jmshrv commented Jul 11, 2021

This seems to only happen on iOS, so it's probably something to do with the audio package I'm using. I'll look into it.

@jmshrv
Copy link
Owner

jmshrv commented Jul 26, 2021

Should be fixed in 4814a88, I'll test it on iOS in a bit

@jmshrv
Copy link
Owner

jmshrv commented Jul 27, 2021

As I said in #86, 4814a88 didn't work so this issue still isn't fixed.

@rom4nik
Copy link
Contributor

rom4nik commented Oct 28, 2021

In my experience this also happens on Android (testing on 5fa8195).

@NotFluffy
Copy link

Still happening on android app version 0.5.1

@MagicRB
Copy link

MagicRB commented Jan 11, 2022

Yep

@jmshrv jmshrv mentioned this issue Mar 16, 2022
@drazil100
Copy link
Author

Still an issue on iOS at least in version 0.6.0.

If it's not easy/possible to get the tools you are using to generate a random queue that doesn't start with the top song of the album/playlist, you could have it pick a random song to start playing and then enable shuffle mode after the fact like you do when you enable it from the now playing screen. May not be the best or most ideal solution but the now playing screen shuffle button works perfectly fine.

@foss-
Copy link

foss- commented Apr 25, 2022

Persisting with 0.6.1 on Android and iOS.

@jmshrv
Copy link
Owner

jmshrv commented May 11, 2022

This is dependant on ryanheise/just_audio#293

@drazil100
Copy link
Author

I still suggest as a workaround to manually randomize what the initial index is before entering shuffle mode. It's a hacky workaround but its better than having to hear the same first song repeatedly every time you shuffle a playlist. Also given it's been almost a year since you posted on that issue I don't expect it to be fixed on their end anytime soon.

@jmshrv
Copy link
Owner

jmshrv commented Jun 5, 2022

A better solution would be to skip once, since then you're only missing one song. It's still not a great solution, but it works for now. I could also something like this:

  1. Put the first song in twice
  2. Skip once
  3. Remove the song in the first position

The code for that would look bad but it should be pretty transparent to the user

@drazil100
Copy link
Author

I don't see a reason to remove it. If you have repeat all enabled it would just become the last song in the shuffle instead of the first.

I am personally on board with this solution for my use case however for shorter playlists (especially if you drop the first song) I think some people might take issue.

@jmshrv
Copy link
Owner

jmshrv commented Jun 6, 2022

This may be fixed in 74cfc09, apparently setting the initial index is a bad idea when shuffling lol. I'm going to make a release now, so hopefully you guys can easily test within a few days :)

@drazil100
Copy link
Author

I'll get back to you as soon as it hits my phone. 👍

@drazil100
Copy link
Author

No luck. Still starts on the first song.

@seniorm0ment
Copy link

I am noticing it seems to start on the first song majority of the time still.
Also the randomness of the shuffle seems very poor. I feel it often plays the same few songs first. And if not the first few it still seems to be just poor randomness.

@AdalynBlack
Copy link

@seniorm0ment I have noticed the same thing. It feels like a lot of the same songs always play, while new songs rarely play if ever. I thought it was just me, but at this point with over 300 songs in my playlist, I'm not so sure

@gzqx
Copy link

gzqx commented Feb 17, 2023

I am noticing it seems to start on the first song majority of the time still.

This is a problem I notice as well.

Also the randomness of the shuffle seems very poor. I feel it often plays the same few songs first. And if not the first few it still seems to be just poor randomness.

I didn't check the code, but I suspect this is not actually the problem of the software. This is a widely known problem of human mind not capable of handling randomness properly. Due to this reason, the shuffle in main stream music service, e.g. apple music is specifically designed to avoid similar pattern to create a randomness that feels more random instead of statistically random.

@seniorm0ment
Copy link

Can confirm this issue is still present, every time I click shuffle it plays the first song in the playlist. Furthermore it seems if Jellyfin is having trouble loading a song or bugging out a bit it flicks back to that first song. A bit difficult to replicate it so not sure what exactly causes it to flick back to it but when it does it's always in a paused state like its thinking "oh im stuck, not sure what to do. Returning to beginning of playlist, and awaiting user to hit play".

As far as the randomness goes, I don't think that's it. I have some big playlists, while I do get randomization it genuinely just seems poor. Sometimes I will even hear the same song twice in a shuffle a few songs apart when it skipped over the other hundred songs in the playlist.

@jmshrv
Copy link
Owner

jmshrv commented Mar 17, 2023

I'm considering switching to an MPV-based player sooner rather than later, so hopefully that'll help (see #177)

@drazil100
Copy link
Author

Hopefully doing so fixes it cause I am tired of the first song in my playlist even though I skip it every time. I'd remove it but then I know I would just get tired of the next song in the list xD

@jmshrv
Copy link
Owner

jmshrv commented Mar 20, 2023

haha yeah I can imagine, might add an option to automatically skip as a temporary workaround

yuruxuan added a commit to yuruxuan/finamp that referenced this issue Apr 30, 2023
jmshrv added a commit that referenced this issue May 10, 2023
Fix shuffle always starts on first song(issues:#61) and remove redund…
@drazil100
Copy link
Author

The new version just went public on the iOS App Store and I wanted to report that this issue has been resolved. 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants