Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🚀 bundler: bump rubocop from 1.60.2 to 1.63.3 #630

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 22, 2024

Bumps rubocop from 1.60.2 to 1.63.3.

Release notes

Sourced from rubocop's releases.

RuboCop 1.63.2

Bug fixes

  • #12843: Fix an error for Lint/MixedCaseRange when a character between Z and a is used in the regexp range. (@​koic)
  • #12846: Fix an error for RuboCop::Lockfile when there is no Bundler environment. (@​koic)
  • #12832: Fix an error for Style/ArgumentsForwarding when using block arg in nested method definitions. (@​koic)
  • #12841: Fix false negatives for Lint/UnreachableLoop when using pattern matching. (@​koic)
  • #12835: Allow global offenses to be disabled by directive comments. (@​earlopain)

Changes

  • #12845: Exclude debug/open_nonstop from Lint/Debugger by default. (@​koic)

RuboCop 1.63.1

Bug fixes

  • #12828: Fix a false positive for Lint/AssignmentInCondition if assigning inside a method call. (@​earlopain)
  • #12823: Fixed "uninitialized constant RuboCop::Lockfile::Bundler", caused when running RuboCop without bundler exec on codebases that use rubocop-rails. (@​amomchilov)

RuboCop 1.63

New features

Bug fixes

  • #12769: Fix a false positive for Lint/RedundantWithIndex when calling with_index with receiver and a block. (@​koic)
  • #12547: Added a comment recommending upgrading to the latest version of Rubocop in the error text when an Infinite loop detected error occurs. ([@​Hiroto-Iizuka][])
  • #12782: Fix an error for Style/Alias with EnforcedStyle: prefer_alias when calling alias_method with fewer than 2 arguments. (@​earlopain)
  • #12781: Fix an error for Style/ExactRegexpMatch when calling match without a receiver. (@​earlopain)
  • #12780: Fix an error for Style/RedundantEach when using reverse_each.each without a block. (@​earlopain)
  • #12731: Treat &. the same way as . for setter methods in Lint/AssignmentInCondition. ([@​jonas054][])
  • #12793: Fix false positives for Style/RedundantLineContinuation when using line continuation with modifier. (@​koic)
  • #12807: Fix false positives for Naming/BlockForwarding when using explicit block forwarding in block method and others. (@​koic)
  • #12796: Fix false positives for Style/EvalWithLocation when using eval with a line number from a method call or a variable. (@​koic)
  • #12794: Fix false positives for Style/RedundantArgument when when single-quoted strings for cntrl character. (@​koic)
  • #12797: Fix false positives for Style/RedundantLineContinuation when using line continuations with && or || operator in assignment. (@​koic)
  • #12793: Fix false positives for Style/RedundantLineContinuation when multi-line continuations with operators. (@​koic)
  • #12801: Fix incorrect autocorrect for Style/CollectionCompact when using delete_if. (@​koic)
  • #12789: Make Style/RedundantPercentQ safe on multiline strings. ([@​boardfish][])
  • #12802: Return global offenses for Naming/FileName and Naming/InclusiveLanguage for empty files. (@​earlopain)
  • #12804: Return global offenses for Style/Copyright when the file is empty. (@​earlopain)

... (truncated)

Changelog

Sourced from rubocop's changelog.

1.63.3 (2024-04-22)

Bug fixes

  • #12857: Fix false negatives for Lint/UnreachableCode when using pattern matching. ([@​koic][])
  • #12852: Fix an error for Lint/EmptyFile in formatters when using cache. ([@​earlopain][])
  • #12848: Fix an error that occurs in RuboCop::Lockfile when the constant Bundler is uninitialized. ([@​koic][])

Changes

  • #12855: Set custom program name for the built-in LSP server. ([@​koic][])

1.63.2 (2024-04-16)

Bug fixes

  • #12843: Fix an error for Lint/MixedCaseRange when a character between Z and a is used in the regexp range. ([@​koic][])
  • #12846: Fix an error for RuboCop::Lockfile when there is no Bundler environment. ([@​koic][])
  • #12832: Fix an error for Style/ArgumentsForwarding when using block arg in nested method definitions. ([@​koic][])
  • #12841: Fix false negatives for Lint/UnreachableLoop when using pattern matching. ([@​koic][])
  • #12835: Allow global offenses to be disabled by directive comments. ([@​earlopain][])

Changes

  • #12845: Exclude debug/open_nonstop from Lint/Debugger by default. ([@​koic][])

1.63.1 (2024-04-10)

Bug fixes

  • #12828: Fix a false positive for Lint/AssignmentInCondition if assigning inside a method call. ([@​earlopain][])
  • #12823: Fixed "uninitialized constant RuboCop::Lockfile::Bundler", caused when running RuboCop without bundler exec on codebases that use rubocop-rails. ([@​amomchilov][])

1.63.0 (2024-04-08)

New features

Bug fixes

  • #12769: Fix a false positive for Lint/RedundantWithIndex when calling with_index with receiver and a block. ([@​koic][])
  • #12547: Added a comment recommending upgrading to the latest version of Rubocop in the error text when an Infinite loop detected error occurs. ([@​Hiroto-Iizuka][])
  • #12782: Fix an error for Style/Alias with EnforcedStyle: prefer_alias when calling alias_method with fewer than 2 arguments. ([@​earlopain][])
  • #12781: Fix an error for Style/ExactRegexpMatch when calling match without a receiver. ([@​earlopain][])
  • #12780: Fix an error for Style/RedundantEach when using reverse_each.each without a block. ([@​earlopain][])
  • #12731: Treat &. the same way as . for setter methods in Lint/AssignmentInCondition. ([@​jonas054][])
  • #12793: Fix false positives for Style/RedundantLineContinuation when using line continuation with modifier. ([@​koic][])
  • #12807: Fix false positives for Naming/BlockForwarding when using explicit block forwarding in block method and others. ([@​koic][])

... (truncated)

Commits
  • a10fbef Cut 1.63.3
  • 21893ac Update Changelog
  • a35ef47 Make InternalAffairs/ExampleDescription aware of an improper description
  • 5706ac0 Remove redundant braces in a few uses of def_node_matcher
  • f1a748b Fix false negatives for Lint/UnreachableCode
  • c30838d [Fix #12848] Fix an error for RuboCop::Lockfile
  • 74037d9 Set custom program name for the built-in LSP server
  • dd47fa8 Merge pull request #12856 from koic/workaround_for_prism_0_26
  • 245b8cc Workaround for incompatibilities between Prism 0.25.0 and 0.26.0
  • d86b8d1 Merge pull request #12853 from Earlopain/global-offense-cache
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.60.2 to 1.63.3.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.60.2...v1.63.3)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from jmuelbert as a code owner April 22, 2024 16:55
@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Apr 22, 2024
@@ -16,7 +16,7 @@ gem "code-scanning-rubocop", "~> 0.6.1"
gem "debug", platform: :mri if RUBY_VERSION >= "3.1.0"
gem "google-protobuf", "~> 3.25.2"
gem "rake", "~> 13.1"
gem "rubocop", "~> 1.60"
gem "rubocop", "~> 1.63"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

@github-actions github-actions bot added the production Production label Apr 22, 2024
Copy link

Here are some friendly prose warnings from write-good:

In ./docs/README.md
=============
All commands are run from the root of the project, from a terminal:
             ^^^^^^^
"are run" may be passive voice on line 30 at column 13
-------------
'src/config.ts' contains several data objects that describe metadata about your 
                         ^^^^^^^
"several" is a weasel word on line 51 at column 25
-------------
he theme's look and feel is controlled by a few key variables that you can custo
                         ^^^^^^^^^^^^^
"is controlled" may be passive voice on line 55 at column 26
-------------
 feel is controlled by a few key variables that you can customize yourself. You'
                         ^^^
"few" is a weasel word on line 55 at column 45
-------------
an customize the page in many different ways to optimize SEO and other things. F
                         ^^^^
"many" is a weasel word and can weaken meaning on line 71 at column 228
-------------
o optimize SEO and other things. For example, you can use the 'title' and 'descr
                         ^^^^^^
"things" can weaken meaning on line 71 at column 274
-------------
description: Really cool docs example that uses Astro
             ^^^^^^
"Really" can weaken meaning on line 76 at column 13
-------------
The sidebar navigation is controlled by the 'SIDEBAR' variable in your 'src/conf
                       ^^^^^^^^^^^^^
"is controlled" may be passive voice on line 87 at column 23
-------------
r navigation has already been created for you.
                         ^^^^^^^^^^^^
"been created" may be passive voice on line 87 at column 191
-------------
top-level 'en' key: This is needed for multi-language support. You can change it
                         ^^^^^^^^^
"is needed" may be passive voice on line 103 at column 34
-------------
### Multiple Languages support
    ^^^^^^^^
"Multiple" is wordy or unneeded on line 105 at column 4
-------------
o docs template supports multiple languages out of the box. The default theme on
                         ^^^^^^^^
"multiple" is wordy or unneeded on line 107 at column 33
-------------
e box. The default theme only shows 'en' documentation, but you can enable multi
                         ^^^^
"only" can weaken meaning on line 107 at column 86
-------------
he default language, you just need to modify the redirect path in 'src/pages/ind
                         ^^^^
"just" can weaken meaning on line 155 at column 56
-------------
nguage, you just need to modify the redirect path in 'src/pages/index.astro':
                         ^^^^^^
"modify" is wordy or unneeded on line 155 at column 69
-------------
 I don't plan to support multiple languages?
                         ^^^^^^^^
"multiple" is wordy or unneeded on line 166 at column 36
-------------
ts need (or can support) multiple languages. You can continue to use this theme 
                         ^^^^^^^^
"multiple" is wordy or unneeded on line 168 at column 60
-------------
 is not English, you can just replace 'en' in directory layouts and configuratio
                         ^^^^
"just" can weaken meaning on line 170 at column 48
-------------
ch.algolia.com/). If you are accepted to the DocSearch program, provide your API
                         ^^^^^^^^^^^^
"are accepted" may be passive voice on line 174 at column 151
-------------
 see where the component is added.
                         ^^^^^^^^
"is added" may be passive voice on line 178 at column 154


In ./docs/src/content/docs/en/introduction.md
=============
By default (without any additional options) this formula install the
                        ^^^^^^^^^^
"additional" is wordy or unneeded on line 22 at column 24
-------------
ehavior or add even more stuff.
                         ^^^^^
"stuff" can weaken meaning on line 24 at column 53
-------------
s all command line tools are installed.
                         ^^^^^^^^^^^^^
"are installed" may be passive voice on line 36 at column 61
-------------
*--HEAD** builds are not really supported. They may fail to install,
                         ^^^^^^
"really" can weaken meaning on line 38 at column 36
-------------
e Qt Installer Framework is located on [https://doc.qt.io/qtinstallerframework][
                         ^^^^^^^^^^
"is located" may be passive voice on line 46 at column 49


In ./.github/PULL_REQUEST_TEMPLATE.md
=============
- [ ] Have you successfully run 'brew tests' with your changes locally?
               ^^^^^^^^^^^^
"successfully" can weaken meaning on line 5 at column 15


In ./README.md
=============
By default (without any additional options) this formula install the
                        ^^^^^^^^^^
"additional" is wordy or unneeded on line 20 at column 24
-------------
ehavior or add even more stuff.
                         ^^^^^
"stuff" can weaken meaning on line 22 at column 53
-------------
s all command line tools are installed.
                         ^^^^^^^^^^^^^
"are installed" may be passive voice on line 34 at column 61
-------------
*--HEAD** builds are not really supported. They may fail to install,
                         ^^^^^^
"really" can weaken meaning on line 36 at column 36
-------------
e Qt Installer Framework is located on [https://doc.qt.io/qtinstallerframework][
                         ^^^^^^^^^^
"is located" may be passive voice on line 44 at column 49
-------------
Many thanks to everyone reporting issues.
^^^^
"Many" is a weasel word and can weaken meaning on line 71 at column 0


In ./SECURITY.md
=============
ions of your project are currently being
                         ^^^^^^^^^
"currently" can weaken meaning on line 5 at column 73
-------------
ur project are currently being
                         ^^^^^^^^^^^^^^^
"being
supported" may be passive voice on line 5 at column 83
-------------
ect if the vulnerability is accepted or declined, etc.
                         ^^^^^^^^^^^
"is accepted" may be passive voice on line 20 at column 51


In ./CODE_OF_CONDUCT.md
=============
* Giving and gracefully accepting constructive feedback
             ^^^^^^^^^^
"gracefully" can weaken meaning on line 22 at column 13
-------------
sing on what is best not just for us as individuals, but for the overall
                         ^^^^
"just" can weaken meaning on line 25 at column 31
-------------
individuals, but for the overall
                         ^^^^^^^
"overall" is wordy or unneeded on line 25 at column 71
-------------
t which could reasonably be considered inappropriate in a
                         ^^^^^^^^^^^^^
"be considered" may be passive voice on line 36 at column 39
-------------
nacceptable behavior may be
                         ^^^^^^^^^^^
"be
reported" may be passive voice on line 61 at column 72
-------------
All complaints will be reviewed and investigated promptly and fairly.
                    ^^^^^^^^^^^
"be reviewed" may be passive voice on line 64 at column 20
-------------
eviewed and investigated promptly and fairly.
                         ^^^^^^^^
"promptly" can weaken meaning on line 64 at column 49
-------------
nvestigated promptly and fairly.
                         ^^^^^^
"fairly" is a weasel word and can weaken meaning on line 64 at column 62
-------------
All community leaders are obligated to respect the privacy and security of the
                      ^^^^^^^^^^^^^
"are obligated" may be passive voice on line 66 at column 22
-------------
te. A public apology may be requested.
                         ^^^^^^^^^^^^
"be requested" may be passive voice on line 81 at column 49
-------------
ing the Code of Conduct, is allowed during this period.
                         ^^^^^^^^^^
"is allowed" may be passive voice on line 103 at column 42
-------------
This Code of Conduct is adapted from the [Contributor Covenant][homepage],
                     ^^^^^^^^^^
"is adapted" may be passive voice on line 117 at column 21
-------------
munity Impact Guidelines were inspired by
                         ^^^^^^^^^^^^^
"were inspired" may be passive voice on line 121 at column 28

Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 29, 2024

Superseded by #636.

@dependabot dependabot bot closed this Apr 29, 2024
@dependabot dependabot bot deleted the dependabot/bundler/rubocop-1.63.3 branch April 29, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file production Production ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants