Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR_Pages_Issues #597

Open
wants to merge 73 commits into
base: main
Choose a base branch
from
Open

PR_Pages_Issues #597

wants to merge 73 commits into from

Conversation

jmuelbert
Copy link
Owner

Resolve Issues on Pages CS-Files and Update Copyright Information to SPDX

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2023

Here are some friendly prose warnings from write-good:

In ./src/jmbde/wwwroot/lib/jquery-validation/LICENSE.md
=============
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
              ^^^^^^
"modify" is wordy or unneeded on line 9 at column 14
-------------
ons to whom the Software is
                         ^^^^^^^^^^^^
"is
furnished" may be passive voice on line 10 at column 67
-------------
d this permission notice shall be included in
                         ^^^^^
"shall" is wordy or unneeded on line 13 at column 54
-------------
 permission notice shall be included in
                         ^^^^^^^^^^^
"be included" may be passive voice on line 13 at column 60
-------------
all copies or substantial portions of the Software.
              ^^^^^^^^^^^
"substantial" is wordy or unneeded on line 14 at column 14
-------------
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
             ^^^^^^^^^^^
"IS PROVIDED" may be passive voice on line 16 at column 13
-------------
NFRINGEMENT. IN NO EVENT SHALL THE
                         ^^^^^
"SHALL" is wordy or unneeded on line 18 at column 66


In ./.github/ISSUE_TEMPLATE/feature_request.md
=============
**Additional context**
  ^^^^^^^^^^
"Additional" is wordy or unneeded on line 21 at column 2


In ./.github/ISSUE_TEMPLATE/bug_report.md
=============
<!-- Your environment is usually important for finding the cause of the bug. -->
                         ^^^^^^^
"usually" can weaken meaning on line 29 at column 25
-------------
**Additional context**
  ^^^^^^^^^^
"Additional" is wordy or unneeded on line 35 at column 2


In ./.github/PULL_REQUEST_TEMPLATE.md
=============
s one or more issues, or is related to another PR, link to them here. -->
                         ^^^^^^^^^^
"is related" may be passive voice on line 10 at column 55
-------------
## How Has This Been Tested?
                ^^^^^^^^^^^
"Been Tested" may be passive voice on line 17 at column 16
-------------
request before all these are done, but they should be done before getting merged
                         ^^^^^^^^
"are done" may be passive voice on line 26 at column 51
-------------
re done, but they should be done before getting merged. -->
                         ^^^^^^^
"be done" may be passive voice on line 26 at column 77
-------------
 If the key of a setting is changed, the 'old' attribute is updated or it is res
                         ^^^^^^^^^^
"is changed" may be passive voice on line 28 at column 30
-------------
ged, the 'old' attribute is updated or it is resolved in
                         ^^^^^^^^^^
"is updated" may be passive voice on line 28 at column 62
-------------
 attribute is updated or it is resolved in
                         ^^^^^
"it is" is wordy or unneeded on line 28 at column 76
-------------
tribute is updated or it is resolved in
                         ^^^^^^^^^^^
"is resolved" may be passive voice on line 28 at column 79
-------------
isplayed in the UI, they are wrapped in 'tr()' or
                         ^^^^^^^^^^^
"are wrapped" may be passive voice on line 30 at column 65
-------------
hanges are notable, they are documented in
                         ^^^^^^^^^^^^^^
"are documented" may be passive voice on line 34 at column 41
-------------
## Additional text
   ^^^^^^^^^^
"Additional" is wordy or unneeded on line 37 at column 3
-------------
the translations need to be updated. --->
                         ^^^^^^^^^^
"be updated" may be passive voice on line 39 at column 102


In ./docs/README.md
=============
s/' directory. Each page is
                         ^^^^^^^^^^
"is
exposed" may be passive voice on line 32 at column 81
-------------
assets, like images, can be placed in the 'public/' directory.
                         ^^^^^^^^^
"be placed" may be passive voice on line 38 at column 36
-------------
All commands are run from the root of the project, from a terminal:
             ^^^^^^^
"are run" may be passive voice on line 42 at column 13


In ./CODE_OF_CONDUCT.md
=============
- Gracefully accepting constructive criticism
  ^^^^^^^^^^
"Gracefully" can weaken meaning on line 16 at column 2
-------------
t which could reasonably be considered inappropriate in a professional setting
                         ^^^^^^^^^^^^^
"be considered" may be passive voice on line 27 at column 39
-------------
 acceptable behavior and are
                         ^^^^^^^^^^^^
"are
expected" may be passive voice on line 31 at column 92
-------------
nacceptable behavior may be reported by contacting
                         ^^^^^^^^^^^
"be reported" may be passive voice on line 50 at column 72
-------------
team is obligated to maintain confidentiality with regard to the reporter of an 
     ^^^^^^^^^^^^
"is obligated" may be passive voice on line 53 at column 5
-------------
enforcement policies may be posted separately.
                         ^^^^^^^^^
"be posted" may be passive voice on line 54 at column 45
-------------
This Code of Conduct is adapted from the [Contributor Covenant][homepage], versi
                     ^^^^^^^^^^
"is adapted" may be passive voice on line 61 at column 21


In ./README.md
=============
jmbde ist ein Programm für das Management von Ressourcen in Unternehmen. Mit die
^^^^^
"jmbde" is repeated on line 9 at column 0


In ./SECURITY.md
=============
ions of your project are currently being supported
                         ^^^^^^^^^
"currently" can weaken meaning on line 5 at column 73
-------------
ur project are currently being supported
                         ^^^^^^^^^^^^^^^
"being supported" may be passive voice on line 5 at column 83
-------------
ect if the vulnerability is accepted or declined, etc.
                         ^^^^^^^^^^^
"is accepted" may be passive voice on line 20 at column 31

@sonarcloud
Copy link

sonarcloud bot commented Jun 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Jun 19, 2023

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
❌ COPYPASTE jscpd yes 202 4.84s
✅ CSHARP csharpier 169 167 0 5.95s
❌ EDITORCONFIG editorconfig-checker 391 1 1.17s
✅ JSON eslint-plugin-jsonc 12 0 0 0.94s
✅ JSON jsonlint 9 0 0.19s
✅ JSON prettier 12 3 0 0.85s
❌ JSON v8r 12 1 9.2s
⚠️ MARKDOWN markdownlint 9 3 3 2.65s
✅ MARKDOWN markdown-link-check 9 0 56.57s
✅ MARKDOWN markdown-table-formatter 9 4 0 0.91s
✅ REPOSITORY checkov yes no 18.86s
❌ REPOSITORY gitleaks yes 5 13.32s
✅ REPOSITORY git_diff yes no 0.09s
✅ REPOSITORY grype yes no 10.11s
✅ REPOSITORY secretlint yes no 2.33s
✅ REPOSITORY trivy yes no 3.58s
✅ REPOSITORY trivy-sbom yes no 0.9s
✅ REPOSITORY trufflehog yes no 3.64s
❌ SPELL cspell 428 1814 133.53s
❌ SPELL lychee 49 354 1.84s
✅ YAML prettier 19 2 0 2.64s
❌ YAML v8r 19 1 29.41s
❌ YAML yamllint 19 1 1.44s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdownlint (reported by Codacy) found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@@ -0,0 +1,47 @@
# This workflow uses actions that are not certified by GitHub.

Check notice

Code scanning / Checkov (reported by Codacy)

Ensure top-level permissions are not set to write-all Note

Ensure top-level permissions are not set to write-all
- OS: [e.g. macOS 10.15 / Windows 10 / Ubuntu 18.04]
- jmbde-aspnet Version: [e.g. 6.0.2]
- OS: [e.g. macOS 10.15 / Windows 10 / Ubuntu 18.04]
- jmbde-dotnet Version: [e.g. 6.0.2]

Check notice

Code scanning / Remark-lint (reported by Codacy)

Warn when references to undefined definitions are found. Note

[no-undefined-references] Found reference to undefined definition
cspell.json Outdated Show resolved Hide resolved
Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bridgecrew has found errors in this PR ⬇️

.devcontainer/docker-compose.yml Show resolved Hide resolved
db:
image: 'microsoft/mssql-server-linux'
environment:
SA_PASSWORD: 'Your_password123' #NO_CHECK

Check notice

Code scanning / Checkov (reported by Codacy)

Base64 High Entropy String Note

Base64 High Entropy String
@jmuelbert jmuelbert enabled auto-merge (squash) September 11, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant