Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR_Pages_Issues #597

Open
wants to merge 73 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 52 commits
Commits
Show all changes
73 commits
Select commit Hold shift + click to select a range
baa103d
Update files...
jmuelbert Jun 17, 2023
f60636b
fix: issues on cs-files in the chipcarddoors directory.
jmuelbert Jun 19, 2023
f12f985
fix: issue on edit..cs. update megalinter.
jmuelbert Jun 19, 2023
7b4352a
fix: resolve issues on pages-build
jmuelbert Jun 19, 2023
a8e5210
fix: resolve issues on found by pre-commit
jmuelbert Jul 16, 2023
b46d7f1
feat: add python ruff to pre-commit
jmuelbert Jul 16, 2023
2605f30
feat: add pre-commit hooks pre-commit
jmuelbert Jul 16, 2023
f6cd180
feat: add hooks to pre-commit
jmuelbert Jul 16, 2023
ca296e8
fix: exclude .cs-files for forbid-tabs pre-commit
jmuelbert Jul 16, 2023
7cc1092
fix: exclude .csproj-files and astro-dir for forbid-tabs pre-commit
jmuelbert Jul 16, 2023
bd0481c
fix: resolve issue on pre-commit
jmuelbert Jul 16, 2023
0a7f617
fix: resolve issue on pre-commit
jmuelbert Jul 16, 2023
9d6f966
fix: pre-commit exclude wwwroot from checking
jmuelbert Jul 16, 2023
3d4ca29
fix: issue on index.rst
jmuelbert Jul 16, 2023
811086d
fix: remove rst, use now astro-docs
jmuelbert Jul 16, 2023
8fbf141
fix: add astro-docs
jmuelbert Jul 16, 2023
eec575c
feat: add toc-tag to README.md
jmuelbert Jul 16, 2023
6cf9a14
feat: set all source files to SPDX license
jmuelbert Jul 29, 2023
6f54d68
feat: remove dockerfile_lint from pre-commit
jmuelbert Jul 29, 2023
c4a6b5b
feat: remove ruby and xml from prettier in pre-commit
jmuelbert Jul 29, 2023
08ebac3
feat: fix format issues with prettier
jmuelbert Jul 29, 2023
de8fad4
feat: remove prettyformat-json use prettier for json in pre-commit.
jmuelbert Jul 29, 2023
fd99801
feat: use toc-builder for README.md
jmuelbert Jul 29, 2023
8624b0a
feat: remove toc-builder for README.md
jmuelbert Jul 29, 2023
d1a724e
feat: add markdownlint config flie
jmuelbert Jul 29, 2023
733d34f
feat: add markdownlint config flie
jmuelbert Jul 29, 2023
240ada8
feat: add markdownlint config flie
jmuelbert Jul 29, 2023
d04b822
fix: resolve an issue on markdownlint.json
jmuelbert Jul 29, 2023
256fad7
fix: resolve an issue on markdownlint.json
jmuelbert Jul 29, 2023
c15288a
fix: resolve an issue on markdownlint.json
jmuelbert Jul 29, 2023
1347f6d
feat: extend markdownlint.json
jmuelbert Jul 29, 2023
4a5dac8
fix: resolve an issue on markdownlint.json
jmuelbert Jul 29, 2023
d4c8853
fix: remove mdlint config, improve prettier.rc and .editorconfig
jmuelbert Jul 29, 2023
c668013
fix: remove mdlint from pre-commit.
jmuelbert Jul 29, 2023
1678550
feat: add xml to prettier.
jmuelbert Jul 29, 2023
00f5083
feat: reformat with prettier
jmuelbert Jul 29, 2023
c610af1
feat: upgrade pre-commit (more checks)
jmuelbert Jul 29, 2023
7e8d46e
fix: reformat files with prettier
jmuelbert Jul 29, 2023
ace717e
feat: upgrade pre-commit (more checks)
jmuelbert Jul 29, 2023
9ed505a
fix: remove dotnet format
jmuelbert Jul 29, 2023
ff508db
fix: remove dotnet format
jmuelbert Jul 29, 2023
dc185f3
fix: remove dotnet format
jmuelbert Jul 29, 2023
bb83627
fix: resolve in pre-commit
jmuelbert Jul 29, 2023
19b9d10
fix: remove editor-file-checker from pre-commit
jmuelbert Jul 29, 2023
ee61ca1
fix: gitleaks-docker from pre-commit
jmuelbert Jul 29, 2023
b83c546
feat: improve clang-format in pre-commit
jmuelbert Jul 29, 2023
cdd54fc
fix: reformat cs files with clang-format
jmuelbert Jul 29, 2023
430f945
fix: Licence-Headers and mega-linter config.
jmuelbert Jul 30, 2023
b48a0e7
fix: disable CS-Format (is only for version 6). reformat all cs-files.
jmuelbert Jul 30, 2023
f9d84c1
fix: resolve merge issues
jmuelbert Aug 5, 2023
4018fa9
fix: small issues
jmuelbert Aug 5, 2023
cb25e01
feat: add workflows and eslinf conf-files.
jmuelbert Aug 6, 2023
e954ee6
fix: fix some issues in docs.
jmuelbert Aug 6, 2023
5b6b58e
fix: issues on solution build and on astro build
jmuelbert Aug 6, 2023
2a39a0b
fix: improve actions security
jmuelbert Aug 6, 2023
b23fa28
fix: syntax issues on gh-actions
jmuelbert Aug 6, 2023
88381e9
fix: remove gitpod support, improve maege-linter checks
jmuelbert Aug 6, 2023
0ff48f8
feat: make pre-commit checks good for dotnet-format
jmuelbert Aug 13, 2023
a5e7d78
fix: remove husky support
jmuelbert Aug 13, 2023
56a0a4a
fix: eol is lf for all files
jmuelbert Aug 13, 2023
0a792f4
fix: issues
jmuelbert Aug 13, 2023
901833c
fix: resolve issues on workflows
jmuelbert Sep 11, 2023
4f4306f
fix: Update workflow, suppress checks in dependabot PR's
jmuelbert Sep 11, 2023
3e486e6
fix: syntax issue
jmuelbert Sep 11, 2023
d2cf779
fix: remove wrong code
jmuelbert Sep 11, 2023
578b99b
feat: optimize the workflow
jmuelbert Sep 11, 2023
83576e9
feat: optimize the workflows
jmuelbert Sep 18, 2023
c4e103f
fix: Issue on assigned-pulls-todo.yml
jmuelbert Sep 24, 2023
9d84873
fix: issue on triage-issues.yml
jmuelbert Sep 24, 2023
90230d0
feat: Create setup-msdo.yml
jmuelbert Sep 30, 2023
744f878
feat: add workflow, optimize workflows
jmuelbert Sep 30, 2023
97315d6
feat: update workflows, remove old files.
jmuelbert Oct 6, 2023
97d11ac
fix: optimize and upgrade
jmuelbert Mar 19, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file removed .direnv
Empty file.
198 changes: 29 additions & 169 deletions .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -4,195 +4,55 @@
# top-most EditorConfig file
root = true

# Default settings:
# A newline ending every file
# Use 4 spaces as indentation
# Unix-style newlines with a newline ending every file
# -----------------
# Source code
# -----------------
[*]
# insert_final_newline = false
indent_style = space
indent_size = 4

[project.json]
indent_size = 2

# C# files
[*.cs]
indent_style = tab

# Modifier preferences
dotnet_style_require_accessibility_modifiers = never:suggestion

# New line preferences
csharp_new_line_before_open_brace = all
csharp_new_line_before_else = true
csharp_new_line_before_catch = true
csharp_new_line_before_finally = true
csharp_new_line_before_members_in_object_initializers = true
csharp_new_line_before_members_in_anonymous_types = true
csharp_new_line_between_query_expression_clauses = true

# Indentation preferences
csharp_indent_block_contents = true
csharp_indent_braces = false
csharp_indent_case_contents = true
csharp_indent_switch_labels = true
csharp_indent_labels = one_less_than_current

# avoid this. unless absolutely necessary
dotnet_style_qualification_for_field = false:suggestion
dotnet_style_qualification_for_property = false:suggestion
dotnet_style_qualification_for_method = false:suggestion
dotnet_style_qualification_for_event = false:suggestion

# only use var when it's obvious what the variable type is
csharp_style_var_for_built_in_types = true:none
csharp_style_var_when_type_is_apparent = true:none
csharp_style_var_elsewhere = false:none

# use language keywords instead of BCL types
dotnet_style_predefined_type_for_locals_parameters_members = true:suggestion
dotnet_style_predefined_type_for_member_access = true:suggestion

# name all constant fields using PascalCase
dotnet_naming_rule.constant_fields_should_be_pascal_case.severity = suggestion
dotnet_naming_rule.constant_fields_should_be_pascal_case.symbols = constant_fields
dotnet_naming_rule.constant_fields_should_be_pascal_case.style = pascal_case_style

dotnet_naming_symbols.constant_fields.applicable_kinds = field
dotnet_naming_symbols.constant_fields.required_modifiers = const

dotnet_naming_style.pascal_case_style.capitalization = pascal_case

# static fields should be PascalCase
dotnet_naming_rule.static_fields_should_have_prefix.severity = suggestion
dotnet_naming_rule.static_fields_should_have_prefix.symbols = static_fields
dotnet_naming_rule.static_fields_should_have_prefix.style = static_prefix_style

dotnet_naming_symbols.static_fields.applicable_kinds = field
dotnet_naming_symbols.static_fields.required_modifiers = static

dotnet_naming_style.static_prefix_style.capitalization = pascal_case

# internal and private fields should be _camelCase
dotnet_naming_rule.camel_case_for_private_internal_fields.severity = suggestion
dotnet_naming_rule.camel_case_for_private_internal_fields.symbols = private_internal_fields
dotnet_naming_rule.camel_case_for_private_internal_fields.style = camel_case_underscore_style

dotnet_naming_symbols.private_internal_fields.applicable_kinds = field
dotnet_naming_symbols.private_internal_fields.applicable_accessibilities = private, internal

dotnet_naming_style.camel_case_underscore_style.required_prefix = _
dotnet_naming_style.camel_case_underscore_style.capitalization = camel_case

# Code style defaults
dotnet_sort_system_directives_first = true
csharp_preserve_single_line_blocks = true
csharp_preserve_single_line_statements = false

# Expression-level preferences
dotnet_style_object_initializer = true:suggestion
dotnet_style_collection_initializer = true:suggestion
dotnet_style_explicit_tuple_names = true:suggestion
dotnet_style_coalesce_expression = true:suggestion
dotnet_style_null_propagation = true:suggestion

# Expression-bodied members
csharp_style_expression_bodied_methods = false:none
csharp_style_expression_bodied_constructors = false:none
csharp_style_expression_bodied_operators = false:none
csharp_style_expression_bodied_properties = true:none
csharp_style_expression_bodied_indexers = true:none
csharp_style_expression_bodied_accessors = true:none

# Pattern matching
csharp_style_pattern_matching_over_is_with_cast_check = true:suggestion
csharp_style_pattern_matching_over_as_with_null_check = true:suggestion
csharp_style_inlined_variable_declaration = true:suggestion

# Null checking preferences
csharp_style_throw_expression = true:suggestion
csharp_style_conditional_delegate_call = true:suggestion

# Space preferences
csharp_space_after_cast = false
csharp_space_after_colon_in_inheritance_clause = true
csharp_space_after_comma = true
csharp_space_after_dot = false
csharp_space_after_keywords_in_control_flow_statements = true
csharp_space_after_semicolon_in_for_statement = true
csharp_space_around_binary_operators = before_and_after
csharp_space_around_declaration_statements = do_not_ignore
csharp_space_before_colon_in_inheritance_clause = true
csharp_space_before_comma = false
csharp_space_before_dot = false
csharp_space_before_open_square_brackets = false
csharp_space_before_semicolon_in_for_statement = false
csharp_space_between_empty_square_brackets = false
csharp_space_between_method_call_empty_parameter_list_parentheses = false
csharp_space_between_method_call_name_and_opening_parenthesis = false
csharp_space_between_method_call_parameter_list_parentheses = false
csharp_space_between_method_declaration_empty_parameter_list_parentheses = false
csharp_space_between_method_declaration_name_and_open_parenthesis = false
csharp_space_between_method_declaration_parameter_list_parentheses = false
csharp_space_between_parentheses = false
csharp_space_between_square_brackets = false

# Xml project files
[*.{csproj,vcxproj,vcxproj.filters,proj,nativeproj,locproj}]
indent_size = 2

# Xml build files
[*.builds]
indent_size = 2

# Xml files
[*.{xml,stylecop,resx,ruleset}]
indent_size = 2

# Indentation override for all JS under lib directory
[*.{js,json,vue,scss,rb,haml,yml,yaml,toml}]
indent_size = 2

[*.{js,json,vue,scss,rb,haml,yml,md}]
indent_style = space
end_of_line = lf
charset = utf-8

# Source code files
[*.{c,cxx,cpp,h,hxx,hpp,java,m,mm,py,swift,xsl}]
indent_style = space
indent_size = 2

[CMakeLists.txt,*.cmake{,.in}]
indent_size = 2
# Caveat: Prettier won’t trim trailing whitespace inside template strings, but your editor might.
# trim_trailing_whitespace = true
insert_final_newline = true
max_line_length = 88

# Configurable Prettier behaviors
# (change these if your Prettier config differs)
end_of_line = lf
indent_style = space

# Override for Makefile
[{Makefile, makefile, GNUmakefile}]
indent_style = tab
indent_size = 4

# Matches multiple files with brace expansion notation
# Set default charset
[*.py]
indent_size = 4
[*.{py,c,cpp,h,toml}]
max_line_length = 80

[*.rst]
indent_size = 3

[*.coffee]
indent_style = space
indent_size = 4
# C# files
[*.cs]
trim_trailing_whitespace = false
insert_final_newline = false

[*.html]
indent_style = space
[*.{yml,yaml,json}]
indent_size = 2

[*.{bat,cmd}]
end_of_line = crlf

[*.{md,markdown,js.snap}]
trim_trailing_whitespace = false
max_line_length = 180

[*.rst]
indent_size = 3

[*.html]
indent_size = 2

[LICENSE]
insert_final_newline = false



5 changes: 5 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
node_modules
docs/node_modules
coverage
app/templates
**/templates
21 changes: 21 additions & 0 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
module.exports = {
"env": {
"es6": true,
"node": true
},
"extends": "eslint:recommended",
"rules": {
"indent": [
"error",
2
],
"quotes": [
"error",
"single"
],
"semi": [
"error",
"always"
]
}
};
13 changes: 6 additions & 7 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
---
name: Bug report
about: Report that something doesn't work as expected
title: ""
title: ''
labels: bug
assignees: ""
assignees: ''
---

**Describe the bug**
Expand All @@ -18,8 +18,7 @@

<!-- If applicable, add screenshots to help explain your problem. -->

**Expected behavior**
A clear and concise description of what you expected to happen.
**Expected behavior** A clear and concise description of what you expected to happen.

**Screenshots**

Expand All @@ -28,10 +27,10 @@
**Environment**

<!-- Your environment is usually important for finding the cause of the bug. -->
<!-- You can get the jmbde-aspnet version by clicking `Help`->`Build Info` in the GUI. -->
<!-- You can get the jmbde-dotnet version by clicking `Help`->`Build Info` in the GUI. -->

- OS: [e.g. macOS 10.15 / Windows 10 / Ubuntu 18.04]
- jmbde-aspnet Version: [e.g. 6.0.2]
- OS: [e.g. macOS 10.15 / Windows 10 / Ubuntu 18.04]

Check notice

Code scanning / Remark-lint (reported by Codacy)

Warn when references to undefined definitions are found. Note

[no-undefined-references] Found reference to undefined definition
- jmbde-dotnet Version: [e.g. 6.0.2]

Check notice

Code scanning / Remark-lint (reported by Codacy)

Warn when references to undefined definitions are found. Note

[no-undefined-references] Found reference to undefined definition

**Additional context**

Expand Down
1 change: 0 additions & 1 deletion .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ about: Suggest an idea for this project
title: ''
labels: enhancement
assignees: ''

---

**Is your feature request related to a problem? Please describe.**
Expand Down
19 changes: 15 additions & 4 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,27 +2,38 @@
<!--- Please follow https://www.conventionalcommits.org/ in the title --->

## Description

<!--- Describe your changes in detail -->

## Related Issues / Pull Requests

<!--- If your PR fixes/resolves one or more issues, or is related to another PR, link to them here. -->
<!--- See: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --->

## Motivation and Context

<!--- Why is this change required? What problem does it solve? -->

## How Has This Been Tested?

<!--- Tested on which OS(s)? Tested on light/dark system theme? -->

## Screenshots (if appropriate)

## Checklist

<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- You can open a pull request before all these are done, but they should be done before getting merged. -->
- [ ] If the key of a setting is changed, the `old` attribute is updated or it is resolved in SettingsUpdater.
- [ ] If there are changes of the text displayed in the UI, they are wrapped in `tr()` or `QCoreApplication::translate()`.
- [ ] If needed, I have opened a pull request or an issue to update the [documentation](http://jmuelbert.github.io/jmbde-aspnet/).
- [ ] If these changes are notable, they are documented in [CHANGELOG.md](https://github.com/jmuelbert/jmbde-aspnet/blob/master/CHANGELOG.md).

- [ ] If the key of a setting is changed, the `old` attribute is updated or it is resolved in

Check warning

Code scanning / Markdownlint (reported by Codacy)

Expected: 80; Actual: 93 Warning

Expected: 80; Actual: 93

Check notice

Code scanning / Remark-lint (reported by Codacy)

Warn when references to undefined definitions are found. Note

[no-undefined-references] Found reference to undefined definition
SettingsUpdater.
- [ ] If there are changes of the text displayed in the UI, they are wrapped in `tr()` or

Check warning

Code scanning / Markdownlint (reported by Codacy)

Expected: 80; Actual: 89 Warning

Expected: 80; Actual: 89

Check notice

Code scanning / Remark-lint (reported by Codacy)

Warn when references to undefined definitions are found. Note

[no-undefined-references] Found reference to undefined definition
`QCoreApplication::translate()`.
- [ ] If needed, I have opened a pull request or an issue to update the

Check notice

Code scanning / Remark-lint (reported by Codacy)

Warn when references to undefined definitions are found. Note

[no-undefined-references] Found reference to undefined definition
[documentation](http://jmuelbert.github.io/jmbde-aspnet/).
- [ ] If these changes are notable, they are documented in

Check notice

Code scanning / Remark-lint (reported by Codacy)

Warn when references to undefined definitions are found. Note

[no-undefined-references] Found reference to undefined definition
[CHANGELOG.md](https://github.com/jmuelbert/jmbde-aspnet/blob/master/CHANGELOG.md).

## Additional text

<!--- Anything else you want to say. For example, mention the translators if the translations need to be updated. --->
14 changes: 7 additions & 7 deletions .github/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# *OPTIONAL* Comment to reply with
# Can be either a string :
requestInfoReplyComment: >
We would appreciate it if you could provide us with more info about this issue/pr!
We would appreciate it if you could provide us with more info about this issue/pr!
# Or an array:
# requestInfoReplyComment:
# - Ah no! young blade! That was a trifle short!
Expand All @@ -14,8 +14,8 @@ requestInfoReplyComment: >
# *OPTIONAL* default titles to check against for lack of descriptiveness
# MUST BE ALL LOWERCASE
requestInfoDefaultTitles:
- update readme.md
- updates
- update readme.md
- updates

# *OPTIONAL* Label to be added to Issues and Pull Requests with insufficient information given
requestInfoLabelToAdd: needs-more-info
Expand All @@ -31,11 +31,11 @@ checkPullRequestTemplate: true
# *OPTIONAL* Only warn about insufficient information on these events type
# Keys must be lowercase. Valid values are 'issue' and 'pullRequest'
requestInfoOn:
pullRequest: true
issue: true
pullRequest: true
issue: true

newPRWelcomeComment: >
Thanks so much for opening your first PR here!
Thanks so much for opening your first PR here!

newIssueWelcomeComment: >
Thanks for opening this issue, a maintainer will get back to you shortly!
Thanks for opening this issue, a maintainer will get back to you shortly!
3 changes: 1 addition & 2 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ updates:
interval: "daily"
commit-message:
prefix: ":rocket: gha"

# Enable version updates for Docker
- package-ecosystem: "docker"
# Look for a `Dockerfile` in the `root` directory
Expand All @@ -39,4 +39,3 @@ updates:
interval: "daily"
commit-message:
prefix: ":rocket: pip"

Loading
Loading