Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JConsoleNameStrategyImpl for generating simple names like JConsole or VirtualVM does #36

Closed
maheshkelkar opened this issue May 27, 2015 · 1 comment
Closed

Add JConsoleNameStrategyImpl for generating simple names like JConsole or VirtualVM does #36

maheshkelkar opened this issue May 27, 2015 · 1 comment

Comments

@maheshkelkar
Copy link
Contributor

As discussed in pull request #29 by @cyrille-leclerc and @petermodzelewski, creating an issue to allow support for: Builds names with general rules like JConsole / VisualVM do.
i.e. .
E.g. For objectName "type:name=metric,value=bar" => getResultName() will return resultName = "type.metric.bar"

Sponsored by: Lookout, Inc.
maheshkelkar added a commit to maheshkelkar/jmxtrans-agent that referenced this issue May 27, 2015
@maheshkelkar
Add JConsoleNameStrategyImpl for generating simple names like JConsol…
ea0eaa4 
…e or VirtualVM

References jmxtrans#29
Fixes jmxtrans#36

Sponsored by: Lookout, Inc.
@maheshkelkar maheshkelkar mentioned this issue May 27, 2015
Closed
maheshkelkar added a commit to maheshkelkar/jmxtrans-agent that referenced this issue May 27, 2015
@maheshkelkar
Do not escape dot from domain of the objectName in JConsoleNameStrategy
daa180a 
Fixes jmxtrans#36

Sponsored by: Lookout, Inc.
maheshkelkar added a commit to maheshkelkar/jmxtrans-agent that referenced this issue May 27, 2015
@maheshkelkar
Added ExpressionLanguageEngine to JConsoleNameStrateyImpl
7d4ac6b 
Derive JConsoleNameStrategyImpl from ResultNameStrategyImpl to avoid code duplication.

Fixes jmxtrans#36

Sponsored by: Lookout, Inc.
maheshkelkar added a commit to maheshkelkar/jmxtrans-agent that referenced this issue May 27, 2015
@maheshkelkar
For bc, reverted ResultNameStrategyImpl and JConsoleNameStrategyImpl …
d6b862a 
…was made standalone.

Fixes jmxtrans#36

Sponsored by: Lookout, Inc.
maheshkelkar added a commit to maheshkelkar/jmxtrans-agent that referenced this issue May 28, 2015
@maheshkelkar
Fix empty resultAlias if not configured in the configuration
a220647 
Fixes jmxtrans#36

Sponsored by: Lookout, Inc.
@kerlandsson
Copy link
Member

From what I can tell this is is now implemented so I'm closing this. Please reopen if I misunderstand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kerlandsson @maheshkelkar