Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expanding possibilities of the agent configuration #29

Closed
wants to merge 1 commit into from
Closed

expanding possibilities of the agent configuration #29

wants to merge 1 commit into from

Conversation

petermodzelewski
Copy link

Adding more power for XML configuration

  • adding support for ALL attributes, when no attribute is specified
  • adding support for ALL keys, when no key is specified for CompositTypes

More general rules for name creation - people who are familiar with JConsole / VisualVM should like such naming utility

  • introduce JConsole like naming strategy

My Idea noticed that one method was not used anymore

  • removed unused method from interface

It generally will run trivial configuration, that will send all jmx data to graphite.

<jmxtrans-agent>
    <queries>                     
        <query/>        
    </queries>
    <outputWriter class="org.jmxtrans.agent.GraphitePlainTextTcpOutputWriter">
        <host>172.17.0.64</host>
        <port>2003</port>
        <namePrefix>offer-parsers-service.</namePrefix>
    </outputWriter>
    <outputWriter class="org.jmxtrans.agent.ConsoleOutputWriter"/>
    <resultNameStrategy class="org.jmxtrans.agent.JConsoleNameStrategy"/>
    <collectIntervalInSeconds>20</collectIntervalInSeconds>
</jmxtrans-agent>

- adding support for ALL keys, when no key is specified for CompositTypes
- introduce JConsole like naming strategy
- removed unused method from interface
@buildhive
Copy link

jmxtrans project » jmxtrans-agent #45 SUCCESS
This pull request looks good
(what's this?)

@cyrille-leclerc
Copy link
Member

Hello Peter,

Thank you very much for your work. Could you please split this in 3 pull requests as I see 3 different things:

  1. Refactor ResultNameStrategy and probably a @Nullable Integer index parameter to the getResultName() method
  2. Then another PR to add JConsoleNameStrategy (with a short description in a javadoc)
  3. And eventually a PR to add the feature "export everything if the query do not define the exact metric to collect

@kerlandsson
Copy link
Member

I'm closing this since from what I can tell this stuff was implemented in other PRs. Please let me know if I'm mistaken.

@kerlandsson kerlandsson closed this May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants