Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the maven compiler flag to use the release flag instead to co… #157

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

endoplasmicR
Copy link
Contributor

…rrectly set the JDK bootclasspath

@endoplasmicR
Copy link
Contributor Author

endoplasmicR commented Mar 1, 2021

@cyrille-leclerc @billonahill
Was still running into the JDK error since the artifact is build using JDK15.
I have verified this build locally using mvn clean install
see
https://stackoverflow.com/questions/43102787/what-is-the-release-flag-in-the-java-9-compiler
for the release flag usage

@cyrille-leclerc
Copy link
Member

@endoplasmicR
Copy link
Contributor Author

Thank you very much @endoplasmicR .
Please test https://github.com/jmxtrans/jmxtrans-agent/releases/tag/jmxtrans-agent-1.2.11-rc-4

hi, @cyrille-leclerc I have tested it out and it is looking good. can you please create a minor version release?

Thank you.

@cyrille-leclerc
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants