100% test coverage

jneen · Aug 25, 2020 · 0577c93 · 0577c93
1 parent 37b45b1
commit 0577c93
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 5 deletions.
diff --git a/test/.eslintrc b/test/.eslintrc
@@ -7,5 +7,8 @@
     "Parsimmon": true,
     "assert": true,
     "testSetScenario": true
+  },
+  "rules": {
+    "no-invalid-regexp": ["error", {"allowConstructorFlags": ["u", "y"]}]
   }
 }
diff --git a/test/core/flags.test.js b/test/core/flags.test.js
@@ -3,19 +3,33 @@
 testSetScenario(function() {
   describe("Parsimmon.flags()", function() {
     it("works in modern browsers", function() {
-      var flags = Parsimmon.flags(/a/gim);
-      assert.strictEqual(flags, "gim");
+      // eslint-disable-next-line no-invalid-regexp
+      var flags = Parsimmon.flags(new RegExp("a", "gimuy"));
+      assert.strictEqual(flags, "gimuy");
     });
 
-    it("works on legacy browsers without Regexp.flags property", function() {
-      var oldRegExp = /a/gim;
+    it("works on legacy browsers without Regexp.flags property with flags", function() {
+      // eslint-disable-next-line no-invalid-regexp
+      var oldRegExp = new RegExp("a", "gimuy");
 
       // Simulate old RegExp without the flags property
       Object.defineProperty(oldRegExp, "flags", { value: undefined });
       assert.strictEqual(oldRegExp.flags, undefined);
 
       var flags = Parsimmon.flags(oldRegExp);
-      assert.strictEqual(flags, "gim");
+      assert.strictEqual(flags, "gimuy");
+    });
+
+    it("works on legacy browsers without Regexp.flags property without flags", function() {
+      // eslint-disable-next-line no-invalid-regexp
+      var oldRegExp = new RegExp("a", "");
+
+      // Simulate old RegExp without the flags property
+      Object.defineProperty(oldRegExp, "flags", { value: undefined });
+      assert.strictEqual(oldRegExp.flags, undefined);
+
+      var flags = Parsimmon.flags(oldRegExp);
+      assert.strictEqual(flags, "");
     });
   });
 });