Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTMLGitlab formatter #268

Closed
wants to merge 1 commit into from
Closed

Add HTMLGitlab formatter #268

wants to merge 1 commit into from

Conversation

rumpelsepp
Copy link
Contributor

Since I want to use "real" rouge for gitlab, we need a proper html
formatter. This pull request adds the needed formatter for gitlab.

See also: gitlabhq/gitlabhq#9341

Since I want to use "real" rouge for gitlab, we need a proper html
formatter. This pull request adds the needed formatter for gitlab.

See also: gitlabhq/gitlabhq#9341
@rumpelsepp
Copy link
Contributor Author

A note to the failing test: Ruby 1.9 is no longer alive!
https://www.ruby-lang.org/en/news/2015/02/23/support-for-ruby-1-9-3-has-ended/

@rumpelsepp
Copy link
Contributor Author

see #269

@jneen
Copy link
Member

jneen commented May 28, 2015

Hey @rumpelsepp, thanks for the PR! This seems to me like a file whose more appropriate home is within the gitlab project. It's mostly the same as the current Formatters::HTML with a few different design decisions.

The direction I'm going for 2.0 is to encourage people to write their own formatters, by having formatters that are easy to extend or compose. There's a branch called refactor.split-html - do you think you could extend from that instead?

@stanhu
Copy link
Contributor

stanhu commented May 28, 2015

I like the idea. There are some changes in the GitLab HTML formatter that I would like to add that shouldn't require upgrading the rouge version.

@rumpelsepp
Copy link
Contributor Author

Alright. So, should I close this?
@stanhu Where do we start with the solution for gitlab?

@stanhu
Copy link
Contributor

stanhu commented May 28, 2015

@rumpelsepp I'm not the authority of this, but I would propose putting it in lib/rouge/formatters/html_gitlab.rb, much like lib/redcarpet/render/gitlab_html.rb.

@jneen
Copy link
Member

jneen commented May 28, 2015

Closing this for now. I suggest using refactor.split-html, which will be later merged into master and released. I'm happy to take a look at whatever solution you end up with and make sure the proper extension points are in rouge so you don't have to maintain a lot of copy/pasta.

@rumpelsepp
Copy link
Contributor Author

Fair enough, thanks!

@rumpelsepp rumpelsepp closed this May 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants