Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons not working #52

Open
DavidG-Aus opened this issue Sep 5, 2021 · 22 comments
Open

Icons not working #52

DavidG-Aus opened this issue Sep 5, 2021 · 22 comments
Labels
bug Something isn't working plugin conflict issue related to another plugin solved workaround documented or fix applied

Comments

@DavidG-Aus
Copy link

I am probably missing something obvious but... I just installed Tab Order and I can't get the icons to work.
Do I need to download the icons from fontawsome and if so where do I put them?

Thanks for all the work you have put into your plugins.

Cheers DG

@jneilliii
Copy link
Owner

There should be a selector on that field.

@DavidG-Aus DavidG-Aus changed the title Icons not workinv Icons not working Sep 6, 2021
@DavidG-Aus
Copy link
Author

I don't see a selector. I am using Firefox but have also tried Chrome and Edge.

image

@jneilliii
Copy link
Owner

Something is not binding properly. Can you check your browser's developer tools on the console tab for errors on initial page load? I know firefox doesn't give as good error messages as chrome in this case.

@DavidG-Aus
Copy link
Author

I tried on chrome. There are a bunch of errors relating to MeatPack plugin but no mention of TabOrder. Are the icons supposed to be on the local machine (Pi) and if so where can I look to confirm they are there?

@DavidG-Aus
Copy link
Author

DavidG-Aus commented Sep 6, 2021

Ah, I just spotted some messages relating to font-awsome
The resource was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it has an appropriate as value and it is preloaded intentionally.
/?#control:1 The resource http://192.168.0.70/static/vendor/font-awesome-5.15.1/webfonts/fa-solid-900.woff?v=5.15.1 was preloaded using link preload but not used within a few seconds from the window's load event. Please make sure it has an appropriate as value and it is preloaded intentionally.

@jneilliii
Copy link
Owner

Ah, that preload error is common, unrelated to the issue. If you disable meat pack does anything change? Force refresh your browser so cache isn't involved. Also check octoprint.log for any errors.

@DavidG-Aus
Copy link
Author

DavidG-Aus commented Sep 6, 2021

Disabling MeatPack gets rid of all the console errors but no change to TabOrder :-(
I can't see anything in OctoPrint.log that seems relevant.

@jneilliii
Copy link
Owner

It's been a while since I've used this plugin, let me check to see what might be going on with it. What version of OctoPrint are you running and what other plugins besides MeatPack do you have installed?

@jneilliii
Copy link
Owner

also, what browser? I just installed fresh on a pi zero w test OctoPrint I had lying around and it is working there so likely some other plugin conflict I suspect.

image

@DavidG-Aus
Copy link
Author

I am running OctoPrint V1.6.1 on OctoPi 0.18.0. I have a bunch of plugins installed. I will try disabling them.
BTW I have a question the Tasmota plugin - it keeps doing a power off sequence every 5 mins (idle timeout) even though the printer is already off. Is that normal?

@DavidG-Aus
Copy link
Author

Here are my plugins (couldn't find a better way to list them):
[{"key": "toptemp", "name": "Top Temp", "url": "https://github.com/LazeMSS/OctoPrint-TopTemp"}, {"key": "UltimakerFormatPackage", "name": "Cura Thumbnails", "url": "https://github.com/jneilliii/OctoPrint-UltimakerFormatPackage"}, {"key": "tasmota", "name": "Tasmota", "url": "https://github.com/jneilliii/OctoPrint-Tasmota"}, {"key": "taborder", "name": "Tab Order", "url": "https://github.com/jneilliii/OctoPrint-TabOrder"}, {"key": "GcodeEditor", "name": "GcodeEditor", "url": "https://github.com/ieatacid/OctoPrint-GcodeEditor"}, {"key": "fullscreen", "name": "Fullscreen Plugin", "url": "https://github.com/BillyBlaze/OctoPrint-FullScreen"}, {"key": "filemanager", "name": "FileManager", "url": "https://github.com/Salandora/OctoPrint-FileManager"}, {"key": "excluderegion", "name": "Exclude Region", "url": "https://github.com/bradcfisher/OctoPrint-ExcludeRegionPlugin"}, {"key": "display_eta", "name": "Octoprint Display ETA", "url": "https://github.com/AlexVerrico/Octoprint-Display-ETA"}, {"key": "cancelobject", "name": "Cancel Objects", "url": "https://github.com/paukstelis/OctoPrint-Cancelobject"}, {"key": "BetterHeaterTimeout", "name": "BetterHeaterTimeout", "url": "https://github.com/tjjfvi/OctoPrint-BetterHeaterTimeout"}, {"key": "autoscroll", "name": "Autoscroll", "url": "https://github.com/MoonshineSG/OctoPrint-Autoscroll"}, {"key": "octoeverywhere", "name": "OctoEverywhere!", "url": "http://www.OctoEverywhere.com"}, {"key": "octodashcompanion", "name": "OctoDash Companion", "url": "https://github.com/jneilliii/OctoPrint-OctoDashCompanion"}, {"key": "webcamtab", "name": "WebcamTab", "url": "https://github.com/gruvin/OctoPrint-WebcamTab"}, {"key": "meatpack", "name": "MeatPack", "url": "https://github.com/scottmudge/OctoPrint-MeatPack"}]

@jneilliii
Copy link
Owner

it keeps doing a power off sequence every 5 mins (idle timeout) even though the printer is already off. Is that normal?

is that after updating just now?

@DavidG-Aus
Copy link
Author

Not sure what you mean about updating? Tasmota plugin is 1.0.4

@jneilliii
Copy link
Owner

thanks, just wanted to make sure it wasn't version 1.1.0 that I just released an hour ago...

try this for me, use the plugin manager to clean up the plugin's settings with the little eraser icon and see if that changes anything. it could be settings corruption. double-check the developer console when opening the pop-up to edit the tab settings.

@DavidG-Aus
Copy link
Author

No change. I got no console messages when I openned the TabOrder edit window.
(Just got another power off countdown)

@DavidG-Aus
Copy link
Author

DavidG-Aus commented Sep 6, 2021 via email

@jneilliii
Copy link
Owner

Only thing I can think of now is disabling all other plugins and see if it still doesn't work.

@DavidG-Aus
Copy link
Author

I disabled all my plugins and then gradually re-enabled them. Success! The plugin causing the problem is... drum roll please... OctoDash Companion. With this plugin enabled the icons are displayed properly, I just can't select any new ones.
Is it possible to design your own icons and if so where are they stored?

@jneilliii
Copy link
Owner

So with that plugin disabled the tab order icon selector works?

@DavidG-Aus
Copy link
Author

DavidG-Aus commented Sep 8, 2021 via email

@jneilliii
Copy link
Owner

Is it possible to design your own icons and if so where are they stored?

Technically, yes you could probably do a custom icon, using css and custom font, but outside of the scope of what I'm willing to implement in the plugin.

@jneilliii
Copy link
Owner

I think I have this issue resolved with the above commit and available as version 1.0.0rc1. You can change the release channel for the plugin to Release Candidate in OctoPrint's software update settings.

@jneilliii jneilliii added bug Something isn't working plugin conflict issue related to another plugin solved workaround documented or fix applied labels Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working plugin conflict issue related to another plugin solved workaround documented or fix applied
Projects
None yet
Development

No branches or pull requests

2 participants