Migrate to npe2 #46
Merged
Migrate to npe2 #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #46 +/- ##
==========================================
- Coverage 80.99% 80.00% -1.00%
==========================================
Files 5 4 -1
Lines 121 115 -6
==========================================
- Hits 98 92 -6
Misses 23 23
Continue to review full report at Codecov.
|
jni
requested changes
Jan 26, 2022
There was a problem hiding this comment.
@jamesyan-git thank you! Left minor comments + changes requested.
This was referenced Jan 27, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates to npe2.
I edited the line in git ignore for version files, because it wasn't working for me.
I have also moved the
start_affinderimport toinitand fixed tests.@jni I think this is ready for review.