Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aligning non-image layers #47

Merged
merged 1 commit into from
Jan 27, 2022
Merged

aligning non-image layers #47

merged 1 commit into from
Jan 27, 2022

Conversation

thanushipeiris
Copy link
Contributor

@thanushipeiris thanushipeiris commented Jan 26, 2022

This PR should address #42 @jni

I just changed two lines - converting the input layer types to the more general napari.layers.Layer instead of napari.layers.Image. It seems to have worked.

Image to shape affine transform
https://user-images.githubusercontent.com/54516770/151113341-4f5185e9-ba83-4344-961b-04d29346c14f.mp4

Image to image transform (is preserved)
https://user-images.githubusercontent.com/54516770/151113418-b21b5c1d-27b6-4c74-aea4-c9353140cdd9.mp4

Note that I'm not actually trying to match anything in these examples! So they look weird. But the affine makes the expected distortions to the moving image.

@jni
Copy link
Owner

jni commented Jan 27, 2022

Thanks @thanushipeiris! I'll merge as soon as tests pass.

Ideally we would update the tests to include testing different layer type combinations, but, given #46 changes the tests and still needs to be merged, I suggest we do that after that gets merged. I'll create a new issue for it.

@jni jni merged commit 6610fdc into jni:main Jan 27, 2022
@thanushipeiris thanushipeiris deleted the align-nonimages branch January 27, 2022 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants