-
Notifications
You must be signed in to change notification settings - Fork 41
New pixel graph implementation #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This new method does not easily support junction centroids so that functionality is removed: only MST junction cleanup is allowed.
Tests are failing because skan isn't able to import a private function from scikit-image. I suspect that the CI is using a newer version of scikit-image where the location of this private utility function has moved. File "/opt/hostedtoolcache/Python/3.9.9/x64/lib/python3.9/site-packages/skan/csr.py", line 6, in <module>
from skimage.morphology._util import _raveled_offsets_and_distances
ImportError: cannot import name '_raveled_offsets_and_distances' from 'skimage.morphology._util' (/opt/hostedtoolcache/Python/3.9.9/x64/lib/python3.9/site-packages/skimage/morphology/_util.py) |
Hm, maybe that's not actually the reason. The |
Turns out it's the other way around. The function So this PR should also update the requirements to specify |
Thanks for reminding me @GenevieveBuckley! tbh I was writing this a while back and I would have had to go figure it out 😂 Probably I'll just vendor the function. |
This is a major change in skan that removes old junction node handling in favour of the new MST junction "cleanup". Building the graph is much faster and we preserve pixel-perfect correspondence between the skeleton graph and the original image.