Make :respect_data_method default to true with capybara/rails #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The alternative of course is adding |
|
➕1️⃣ I think a lot of people will get bad headaches when they bump into this unexpected behavior. |
jnicklas
added a commit
that referenced
this pull request
Aug 30, 2012
Make :respect_data_method default to true with capybara/rails
|
Alright. Let's do it this way. |
|
Cool, thanks :) |
|
Awesome, thanks for merging! |
carlosantoniodasilva
referenced
this pull request
Feb 26, 2013
This change enables the `:respect_data_method` option from the RackTest driver for Rails projects that don't use RSpec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm writing an upgrade guide, and I find myself telling people "Capybara 2.0 will break your test suite. To stop it from breaking your test suite, enable
:respect_data_method." This is something that we'll basically have to tell all users, or they'll get tripped up.Instead, I'd suggest that we enable the right behavior by default, whenever
capybara/railsis required.Ignoring data-method in the RackTest driver is very reasonable when we're not testing Rails apps, for what it's worth. But in Rails apps, people will generally want to honor data-method.