Apple Silicon support #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cannot be a submodule until we upstream our mips64el tweaks.
headius
force-pushed
the
apple_arm64
branch
2 times, most recently
from
3ad89d3
to
60b8f95
Compare
|
Fixes #92. |
headius
force-pushed
the
apple_arm64
branch
2 times, most recently
from
fa7fc24
to
76c49d6
Compare
|
Holding off on merging this due to failures in jnr-ffi that may require further libffi patches: https://gist.github.com/headius/153c43133aafa6d7820bf00c6a68cb7b |
|
@larskanis This is nearly 100% other than the varargs failures in jnr-ffi. Perhaps you will be able to learn something from this for the ffi gem? Have you any thoughts on these varargs failures? It seems like it is just passing the wrong varargs layout through to |
|
Merging to continue progress. Unsure at this point if the variadic failures are due to bugs in jffi or jnr-ffi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges in the leading edge of https://github.com/libffi/libffi, including a few tweaks from @atsweet and others for Apple arm64 support. We cannot yet use a submodule for our libffi due to libffi/libffi#630.
We would like to go with a release, but this version passes all tests on the platforms we have available and appears to be working well on Apple Silicon.
Notes:
ffi_closure_allocto avoid crashing when attempting to set the closure's memory page executable. This change came from ffi/ffi@2c9c517 by @Watson1978.One there is a proper libffi release that incorporates our mips64el tweaks from #83 we will switch to using a git submodule.