Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for mips64el #83

Merged
merged 1 commit into from
Sep 9, 2020
Merged

add support for mips64el #83

merged 1 commit into from
Sep 9, 2020

Conversation

huiji12321
Copy link
Contributor

I worked with an computer which architecture is mips64el,And ported jnr/jffi using my computer,can this be able to merge? or how to merge?
If you need environment to test,I can also offer one Cloud Account.
THANKS!

@headius
Copy link
Member

headius commented Sep 9, 2020

Sorry for the delay looking into this. Thank you for the changes! I am happy to merge, but please contact me directly (email my username @ my username dot com) so I can confirm using your cloud account that this is all good.

@headius headius added this to the 1.2.24 milestone Sep 9, 2020
@headius headius merged commit 61a60b0 into jnr:master Sep 9, 2020
This was referenced Mar 23, 2021
@headius
Copy link
Member

headius commented Jun 15, 2021

Hey @huiji12321 @merore could you respond to @atgreen's comments?

@merore
Copy link

merore commented Jun 17, 2021

@atgreen @huiji12321
Yes, I agree with @atgreen. All in all, these two definitions are redundant. MIPS has three ABI: O32,N32 and 64. @huiji12321 ported this with mips64, which ABI is 64 and compatible with N32. So line 61 in ffitarget.h check that if _ABI64 is defined defined FFI_MIPS_N32.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants