Feature and Gate Tweaks #45

jnunemaker · 2015-04-03T22:05:32Z

Mostly internal changes but a few public ones.

moves typecasting to module and out of gate values
moves gate instrumentation to feature, will make it easier to allow tweaking gates per feature in the future
adds Feature#disabled_groups
Flipper.groups and .group_names now return a set to be consistent with intention and the rest of flipper. Perhaps I should change everything to arrays and drop the Set idea as it is kind of just annoying in ruby.

fyi @rsanheim @dewski @aroben

No need for feature name everywhere in gate. This feels like a step in right direction. Still more tweaks to come.

Only gate open? is instrumented and having it in gate requires passing it to gate from feature.

…rcentage gates

disabled_groups

Conflicts: lib/flipper/feature.rb lib/flipper/gate_values.rb spec/flipper/gates/percentage_of_time_spec.rb

No longer used.

Seems like it could be dangerous if anything that used these modified them in place

No longer used

Not needed. Can always add back if we need to check the source of the memory adapter.

Feature and Gate Tweaks

rsanheim · 2015-04-07T21:45:09Z

lib/flipper/feature.rb

    def percentage_of_time_value
      gate_values.percentage_of_time
    end

    # Public: Returns the string representation of the feature.
    def to_s
-      @to_s ||= name.to_s
+      name.to_s


rsanheim · 2015-04-07T21:47:12Z

Perhaps I should change everything to arrays and drop the Set idea as it is kind of just annoying in ruby.

Agree with this, sets just don't feel needed with what we are doing here.

jnunemaker added 21 commits April 3, 2015 16:17

Move feature name to parameter on open? from Gate#initialize

bd6c479

No need for feature name everywhere in gate. This feels like a step in right direction. Still more tweaks to come.

Move gate instrumentation to feature

929da17

Only gate open? is instrumented and having it in gate requires passing it to gate from feature.

Use gate value typecasting instead of just to_i for open? check in pe…

eaf1a86

…rcentage gates

Move typecasting to Typecast module from GateValues

161f635

Alias Feature#groups as #enabled_groups

295ed56

Flipper group and group_names should be Set like everything else

9309a00

Add Feature#disabled_groups

e63c51d

Make enabled_groups the method and alias groups to be consistent with

5b634a4

disabled_groups

Merge branch 'master' into gate-tweaks

06328e0

Conflicts: lib/flipper/feature.rb lib/flipper/gate_values.rb spec/flipper/gates/percentage_of_time_spec.rb

Stop passing instrumenter to gate

0dadd50

No longer used.

Check gate instance type instead of using gates

21876ba

Denote features as public

c205f6a

Denote key as public

d40e4ee

Remove memoization from to_s and to_param

02f4257

Seems like it could be dangerous if anything that used these modified them in place

Update docs for feature

052dbe5

Remove gate enable/disable

c34ea39

No longer used

Add name, key and data type to gate inspect

a98742d

Remove source from specs

a2e45a9

Not needed. Can always add back if we need to check the source of the memory adapter.

Update spec/docs for integration spec

482deff

Ensure that GateValues#[] returns nil for bad ivar

fc975f7

Document legit ivars constant

c6a3211

jnunemaker self-assigned this Apr 4, 2015

jnunemaker pushed a commit that referenced this pull request Apr 4, 2015

Merge pull request #45 from jnunemaker/gate-tweaks

25ceb11

Feature and Gate Tweaks

jnunemaker merged commit 25ceb11 into master Apr 4, 2015

jnunemaker deleted the gate-tweaks branch April 4, 2015 18:53

rsanheim reviewed Apr 7, 2015
View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature and Gate Tweaks #45

Feature and Gate Tweaks #45

jnunemaker commented Apr 3, 2015

rsanheim Apr 7, 2015

rsanheim commented Apr 7, 2015

Feature and Gate Tweaks #45

Feature and Gate Tweaks #45

Conversation

jnunemaker commented Apr 3, 2015

rsanheim Apr 7, 2015

Choose a reason for hiding this comment

rsanheim commented Apr 7, 2015