Redirecting to locations containing a parent or current directory reference #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| it "redirects if a 300 contains a relative location header with a current directory path" do | ||
| redirect = stub_response '', 300 | ||
| redirect['location'] = './foo/bar' |
There was a problem hiding this comment.
Is this actually legal according to RFCs?
There was a problem hiding this comment.
Nope, should be absolute but I've run across it and browsers respond accordingly.
|
Not really sure what to do with this, so I'm closing. Feel free to re-open if you/anyone feel really passionate about it and can explain it a bit more to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having some problems with redirects on a site that redirected to locations using parent and current directory references. This pull request contains a small change to handle those types of locations.
Neil.