Skip to content
This repository has been archived by the owner on Jun 25, 2023. It is now read-only.

Add support of new syntax Allowed-Origins #59

Closed
wants to merge 1 commit into from

Conversation

VoidAndAny
Copy link

Specifically for Ubuntu Bionic Beaver and more

Specifically for Ubuntu Bionic Beaver and more
@dnrce
Copy link
Contributor

dnrce commented Jan 17, 2020

Origins-Pattern is the "new" option: mvo5/unattended-upgrades@f29c8f9

@jnv
Copy link
Owner

jnv commented Jan 20, 2020

Sorry, I kinda abandoned this repo for a while. Let's see, the PR is fine, I am mostly missing a README entry for this option. I also wonder whether the inclusion of per-distro defaults could be simplified via lookup, but since we are dealing with version range, I doubt it.

@@ -0,0 +1,5 @@
---
__unattended_allowed_origins:
- '${distro_id}:${distro_codename}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question on this part!

For Ubuntu 16, there is only -security currently if you use the role, by default:

---
__unattended_origins_patterns:
- 'origin=Ubuntu,archive=${distro_codename}-security,label=Ubuntu'

If I understand well, the line above is introducing a change in default behaviour, is that correct @VoidAndAny?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I found more information which seems to indicate that:

The first origin "${distro_id}:${distro_codename}" is necessary because security updates may pull in new dependencies from non-security sources. This origin doesn’t provide software updates.

So this makes sense! If anyone with more expertise on that part can comment, it's still welcome 😄

@jnv
Copy link
Owner

jnv commented May 23, 2022

I am closing this PR since this role has been deprecated. Feel free to suggest alternatives in #98.

@jnv jnv closed this May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Allowed-Origins (used by default in Ubuntu 18.04)
4 participants