M1 fixes #76
Closed
M1 fixes #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* modify navbar * remove unused function causing frontend coverage failure * adjust user-flows * address AT review comments * address comments1 * fix i18n issue of impact section * fix angular modules issue in ATs
…ploration (oppia#20557) * Create frontend modal with list of translations populated * Display language names appropriately * Stylize scrollbar and fix displaying rich text elements * Fix button styles * Handle populating draft translation changes appropriately * Add comments for clarity * Handle cases where translations have been removed and no translations are available * Handle logic for removing published as well as draft translations appropriately * Add frontend tests * Write acceptance tests * Fix lint errors and convert backend dicts appropriately * Fix merge conflict * Fix lint issue * Fix typescript issues * Fix merge issue * Fix frontend test failure * Fix acceptance testing, add feature flag utility * Fix merge issues * Fix lint issues * Fix typo * Make release coordinator page responsive and fix acceptance testing * Fix lint issues * Fix e2e test failing * Attempt to fix acceptance test * Remove acceptance test from CI * Add todo comment for acceptance testing * Address comments * Generalize CD translation modal component * Make backend changes to mark only specific language translation as needing update * Fix cancel flow and setting data format * Set content type appropriately and write frontend tests * Add frontend tests * Write backend and acceptance tests * Fix lint issues * Fix lint issues * Fix lint issues * Fix type check * Fix frontend test failure * Fix modal population and import declaration * Fix typo * Attempt to fix module import * Add loading indicator * Fix minor modal population bug * Add functionality to display translation change diff * Maintain data of last published translations in order to compare changes * Write frontend tests * Fix lint issues * Fix typescript issue * Add margin to button * Remove resetting latest translations * Sort bulk translation data for appropriate comparison * Add frontend test and fix modal header * Fix typo * Fix translation objects being initialized without any existing translations * Prevent empty translation changes from being added * Fix active written translation being initialized * Fix typo * Gate API call behind feature flag * Fix lint issues * Move feature flag to TEST stage * Capitalize YAML
…questions (oppia#20248) * Added Dummy Suggestion feature * lint fix * Correcting the failing tests * adding test for debugging * Added question submitter permission for test * Corrected the failing test * Added tests to cover the code
* Add partnerships,hero sections * add auto-play for carousel as suggested today * Fix build test * fix lighthhouse issues * address comments 1 * fix an angular module issue of ATs
* Removed cd accomplishment flag code * Fixed the issue raised by the backend test.
* Fix part of oppia#19849: Update classroom admin page * Show publish and save warning * minor fix * add function for saving images * minor fix * add test for fs_service * minor update * fix e2e test * add test for classroom controller * add check for topic count * fix test * Add test for invalid image * remove unused code * refactor code * fix test * add classroom data * fix test * fix test * add precheck * change function name * update aspect ratio * fix linter * fix entity type
… for Admin Page Feature Tab CUJs (oppia#20536) * updates * updates * updates * Updates * Updates * updates * updates * updates * updates * updates --------- Co-authored-by: Justin Nguyen <jn-nguyen@outlook.com>
…ppia#20419) Redirect to login page on error The changes were done in preferences-page-root.component.ts and preferences-page-root-componente.spec.ts: Previously, the preferences page would handle errors by showing an error page when there was an issue with validating the user's ability to manage their own account. This was done in the case that an error happened when executing the 'validateCanManageOwnAccount' method. Now, instead of showing an error page, the user is redirected to the login page. This is achieved by modifying the code in preferences-page-root.component.ts and calling 'this.router.navigate' when an error happens, instead of 'errorPageIsShown = true'. The login page route is constructed using the 'AGES_REGISTERED_WITH_FRONTEND.LOGIN.ROUTE' constant from AppConstants. Additionally, a 'return_url' query parameter is passed to the login route because the user is supposed to automatically return to the preferences page after the login is made. In the preferences-page-root-componente.spec.ts one test case was modified: The test case 'should initialize and show error page when server respond with error' was updated and renamed to 'should initialize and redirect to login page when server respond with error'. Previously, this test case checked that the error page would be shown in case of an error. Now, it checks that the user is redirected to the login page in case of an error with the correct route and 'return_url' query parameter and also checks that neither the preferences page or the error page was shown, since the user was redirected to the login page. Co-authored-by: Kevin Thomas <kevintab@tutanota.com>
* update ATs * remove AT part * remove the route and misc code related to AF page * remove navbar test * address AT review comments * correct the url * unused images
… page (oppia#20534) swapped partner2 and partner3 image names so that they display at their intended places. Co-authored-by: Hardik Goyal <135348086+HardikGoyal2003@users.noreply.github.com> Co-authored-by: Afzal Khan <tricktomade@gmail.com>
* Fix part of oppia#19849: Update classroom page * fix style * add i18n * fix i18n keys order * fix classroom test * remove line * add dot at the end * minor changes --------- Co-authored-by: Kevin Thomas <kevintab@tutanota.com>
…for Admin Page Feature Tab CUJs (oppia#20575) * updates * updates * updates * updates
…n the number (oppia#20540) blog_pagination
* fixed git not recognizing repo as safe * updated Makefile to make /app/oppia as safe dir for git * updated pre-commit not to start dev-server * updated pre-commit not to start dev-server * added comments in pre-commit hook * updated variables and their usage in pre-commit-hook.sh --------- Co-authored-by: Hardik Goyal <135348086+HardikGoyal2003@users.noreply.github.com>
…changed and add it to the github workflow. (oppia#20500) * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Updates * Fix Merge Error * Fix Merge Error
* Fix all UI bugs * fix cta carousel in rtl and add frontend tests * Add impact report AT * [GSoC'24] M1.13, Fix a part of oppia#20374: Acceptance test coverage for Admin Page Feature Tab CUJs (oppia#20575) * updates * updates * updates * updates * Fix gap * Revert "[GSoC'24] M1.13, Fix a part of oppia#20374: Acceptance test coverage for Admin Page Feature Tab CUJs (oppia#20575)" This reverts commit 9f803e2. --------- Co-authored-by: Akhilesh Kr <2827daya@gmail.com>
…a#20581) * Fix part of oppia#19849: Classrooms project bug fixes * add check when saving a published classroom * fix a11y and classroom admin page mobile * fix linter * minor fixes * simplify code * fix topic issue
…or 2 release coordinator's CUJs (oppia#20508) * updates * updates * updates * updates * updates * updates * updates * updates * updates * updates * updates * updates * updates * updates * updates * updates * updates * updates * Updates * Updates * updates * updates * updates * updates * updates * updates * updates * updates * updates * updates * updates * updates * updates * updates * updates * updates --------- Co-authored-by: Justin Nguyen <jn-nguyen@outlook.com>
…ag to test stage (oppia#20599) Fix part of oppia#19849: Move multiple classroom feature flag to test
Fix both the errors
…rtnerships-page-brochure-button failed (oppia#20609) Fix the flake
* Improve modal CSS * Tick checkbox on saving a translation * Update button text for clarity * Show subsidiary modal only when editable translations exist * Verify if RTE components of modified translation match when updating translation * Add missing languages to supported content language list * Fix frontend tests * Fix acceptance test * Fix bugs pertaining to stale and empty translations * Fix linter issues * Gate translation changes button behind feature flag * Fix frontend test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.