[wip] fix: support couchdb 2.x #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm! |
|
It has been brought to my attention that CouchDB nodes do not gossip config information, so this PR will need to be updated so that config data is written to each node, rather than to the local one only. |
|
I've updated the PR so that each node in a cluster is configured individually. |
|
Hey @garbados, I have merged and released your couchdb-configure adaption to clustered couchdb versions. And this project is now also on GH actions, where I set up a test matrix against various couch and node versions. Now I have rebased your changes here: #58 - there are some test errors with couch 2 and 3 - could you have a look? I have added you to this repo so that you can work here directly and push to the new branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for 2.x and 3.x installations of CouchDB, which use a
_node/${nodeName}/_configpath for interacting with configuration settings, while retaining support for 1.x instances. It does this by determining the installation's version number and then setting the configuration path to either_configor_node/_local/_config. A node within a cluster will then distribute these updates to its peers.These changes depend on this PR in couchdb-configure, and include it as a dependency in order to demonstrate compatibility. This dependency should be changed back to mainline couchdb-configure once that PR is merged, before this PR is merged.