-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scalafix 0.10.0 #91
scalafix 0.10.0 #91
Conversation
@joan38 any chance you can approve the worflow to run so I get feedback? Thanks in advance! |
Done |
Thanks, it looks good. Once the final release is cut, it would be nice to get a major release of your client ASAP. That's because of the breaking change explained in https://github.com/scalacenter/scalafix/releases/tag/v0.10.0-RC1: if rules start building against scalafix 0.10.x, they will unfortunately fail at runtime with existing clients using scalafix 0.9.x (scalacenter/scalafix#1562 tried to improve the error message, but it's not trivial). OrganizeImports being the most widely used one, let's wait until a 0.10.x-built mill-scalafix release is published to publish a 0.10.x-built OrganizeImports, as suggested in liancheng/scalafix-organize-imports#264. |
Thanks @bjaglin for taking care of this! |
@joan38 0.10.0 is out |
Hi @joan38, I'm Razvan, GSoC contributor for scalafix and @bjaglin is my GSoC mentor. TLDR: We'd like a release of mill-scalafix which includes this PR. As part of the project I'm cross compiling scalafix in scala 3, however in scalafix-core there's a macro for better error message / readability. Would this be possible? |
Hi @rvacaru ! |
Also note that we have snapshot releases on every commit, the latest being |
|
Thanks a lot for the quick response @joan38! :) |
See https://github.com/scalacenter/scalafix/releases/tag/v0.10.0.