WIP: New unit tests for cl-lib #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joaotavora looks like I have a bit of downtime this week so I am just going to continue writing unit tests... just pushed the unit tests for As always, let me know if the whitespace cleanup is unwelcome. I haven't changed any documentation yet, I am just writing unit tests. |
|
lol I came around to just removing my whitespaces changes, i realized they made everything a nuisance to read. Just adding unit tests for now... |
|
I will work to submit this upstream myself, thanks! |
joaotavora
pushed a commit
that referenced
this pull request
Jul 15, 2024
* lisp/erc/erc.el (erc--message-speaker-ctcp-action-input) (erc--message-speaker-ctcp-action-statusmsg-input): Don't use shared/circular references, like #1=foo ... #1#, in literal strings because it triggers CI validation failures. These message-format definitions were originally introduced as part of bug#67677.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know if I should remove the whitespace cleanup of
cl-lib.el... I figured we might as well do it while we are in here, but I know the Emacs maintainers dislike it.I will submit a PR covering one cl-lib file and its associated tests at a time so that I can incorporate your feedback.