This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
send editingChanged action when editing #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorBaro
suggested changes
Apr 30, 2018
| @@ -531,6 +531,7 @@ extension AnimatedTextInput: TextInputDelegate { | |||
|
|
|||
| open func textInputDidChange(textInput: TextInput) { | |||
| updateCounter() | |||
| sendActions(for: .editingChanged) | |||
There was a problem hiding this comment.
I don't understand... what is sendActions(for: ) ? Is this an extension?
Please provide an implementation for this method, otherwise, the project won't compile.
There was a problem hiding this comment.
Since you're subclassing UIControl, it is good practice to send out appropriate UIControlEvents, eg in this case when text changes occur (cfr https://developer.apple.com/documentation/uikit/uicontrol).
victorBaro
approved these changes
Jul 17, 2018
| @@ -531,6 +531,7 @@ extension AnimatedTextInput: TextInputDelegate { | |||
|
|
|||
| open func textInputDidChange(textInput: TextInput) { | |||
| updateCounter() | |||
| sendActions(for: .editingChanged) | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be able to bind the
textvalue of theAnimatedTextInput(eg when using RxSwift), the.editingChangedcontrol event needs to be sent when the text is changed.