-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Javascript Error (recRule.getComponent is not a function) #37
Comments
Please retry with beta4 and report, if the error remains |
Thanks for the reply! recRule.getComponent is not a function sync.js:223
eas.sync.getItemRecurrence chrome://tbsync/content/provider/eas/sync.js:223:33
eas.sync.Calendar.getWbxmlFromThunderbirdItem chrome://tbsync/content/provider/eas/calendarsync.js:247:26
eas.sync.sendLocalChanges< chrome://tbsync/content/provider/eas/sync.js:552:62
InterpretGeneratorResume self-hosted:1213:8
next self-hosted:1120:9
TaskImpl_run resource://gre/modules/Task.jsm:319:42
bound TaskImpl_run self-hosted:957:17 |
hm, that is odd. Can you send me a full debug log? I would like to look at the actual data being processed. Debug log can be enabled at the help tab in the account manager. What kind of system/environment is this? |
I think it's an RDATE rule. I've started on something to support it, but there doesn't seem to be any way to make such an event from within Thunderbird or Outlook so I'll have to get creative with the testing. EDIT: |
I actually do not know what you are talking about :-) The error happens while trying to sync something from Thunderbird to the EAS server, right? I am officially lost. |
An RDATE is an exception that adds an extra occurence. I say that this is the issue because that type of recRule does not have a Related, there is also EXRULE, which defines a recurring exception, which isn't checked for or handled correctly. EAS doesn't support either of these rule types, so I was wondering if they should just be ignored. |
@ChrisJAllan So if such events cannot be placed into the TB calendar during the initial sync, the user must have added this event by himself? Can you reproduce that? If it is not supported by EAS at all, shouldn't we be able to catch those events by
and simply ignore them? @ricleal Does any of this sound familiar? Did you somehow added an event with exception to your calendar? |
The only way I found to recreate this was to manually modify an iCal file, import it, and copy the event into the TbSync calendar. PR #38 deals with them. |
I have no idea. Is there a way I could remove the calendar cache (not all Thunderbird cache) and re-sync everything? |
No, please do not remove anything from your calendar, I will release a new beta shortly. But I have a question: Your calendar contains a recurring event, which is using a recurrent format that is not supported by EAS. Probably RDATE which adds an "extra" occurence to a series. We ignore this extra occurence. If you ever delete your local thunderbird calendar and than sync the calendar fresh from your server to Thunderbird, that extra occurence will not show up anymore. TbSync does not have a way to inform users about such things (except the debug log, which logs way to much for everyday usage). What I could do, is sending you an E-mail notification (to be precise, your EAS server is sending it), that informs you about the situation. Would that be "too much"? |
That makes sense! I created a recurring event using the Thunderbird calendar... |
No that is not what I mean. I am thinking about implementing an automatic notification email which is send by TbSync (via your EAS account) to inform you about such a situation. But that is not so important. Much more interesting is your other remark. Can you recall what exactly you did with that calendar, after you initially synced it down from your server? Did you import anything from an iCal file or did you simply add an recurring event? What kind of recurrence? |
LOL! |
can you remove that recurring event and try to sync? does it work? |
I had done that.
|
Please try again with beta7. |
It fails with a different message.. Here's the log (removed attendees and text):
|
Why is he trying to add tons of new items to the server, if you just changed one? Can you please start from scratch? Disconnect account and reconnect. And than make a change to the calendar and sync. |
The event on 2018-01-18 (Monthly Meeting for the ECS initiative) is the issue. It doesn't have a recurrence rule, only a date (which is ignored), and then an exception for that event, which fails as there is no recurrence to modify. I have no idea how an event ended up this mangled or how to deal with it. Was that one created in Thunderbird or somewhere else? |
It works now :) Disconnected the account and reconnected it again. I didn't do it before because I thought that I would lost the cache (12h synchronising all the stuff...). |
@ricleal Can you re-add the event with the recurrence we are talking about? What happens if you try to sync after that? |
@ricleal Does that event actually occur monthly? There doesn't seem to be any monthly rule on it. It seems the best solution would be to delete and re-create that event. |
If I create a bi-weekly event I have the same problem :(
|
full log please |
Monthly is OK! |
Don't ask me why, it works now with bi-weekly, weekly, etc... |
no, that is a bug in tbSync. After he failed to sync the "bad" event, he forgets about it and next time you sync, he does not include it. But it has not yet been synced Please start from scratch again, add a bi-weekly meeting. Restart TB (to clear the log) and sync and send the full log of the error. |
Make sure it actually shows up on the remote server before saying "it works." |
I can't repeat the error. everything is OK. The remote calendar is updated after the synchronisation for any type of recurring events. I will update this issue if the problem arises again. |
I am not able to reproduce the bad event stated in the log, starting from a be-weekly recurrence pattern. This is so strange... |
do not add exceptions tag, if we have not added a recurrence tag
Please update to beta1, it contains a few more sanity check. |
Can this issue be considered as solved? |
I have had no further issues. From my side yes, you can close the issue. |
Sorry to open this again..
|
That is a different error, I do not see any reference to recRule.getComponent. Please open a new issue for this. You do not need to include the log again |
Hi!
Great peace of software.
I'm just reporting an issue I'm having synchronising with activesync.
The GUI shows:
Calendar : Javascript Error: Check Debug
, and the debug console the following:I hope you can fix that! Let me know if you need further info.
Thanks
The text was updated successfully, but these errors were encountered: