[MRG] WindowsError should be a type under non-Windows platforms #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You could get "TypeError: catching classes that do not inherit from BaseException is not allowed" when hitting Control-C.
Codecov Report
@@ Coverage Diff @@
## master #494 +/- ##
==========================================
+ Coverage 93.94% 94.01% +0.06%
==========================================
Files 36 36
Lines 4575 4576 +1
==========================================
+ Hits 4298 4302 +4
+ Misses 277 274 -3
Continue to review full report at Codecov.
|
|
I just wanted to check everything was fine with the CIs and I am going to merge this one. |
yarikoptic
added a commit
to yarikoptic/joblib
that referenced
this pull request
Nov 3, 2017
* tag '0.11': (60 commits) Add configuration for readthedocs Minor fixes in CHANGES.rst Set relase version to 0.11 Add 0.11 section to changelog Fix rst for correct rendering on PyPI MAINT update release instructions to use twine [MRG] Fix AppVeyor test exit code (joblib#505) [MRG] turn warnings into error in the doc generation (joblib#504) MAINT replace py.test by pytest MAINT remove most warnings from documentating the doc Shorter error message when cache results can not be loaded. (joblib#501) Replace deprecated logging.warn by logging.warning add pypi badge to readme and move the bagdes to the top (joblib#500) Enable codecov on AppVeyor (joblib#497) Improve folder organisation for CI files (joblib#499) Revert flake8 version to 2.5.1 Use Python 3.5 on AppVeyor (joblib#495) Fix race condition in Memory when persisting output in parallel (joblib#491) WindowsError should be a type under non-Windows platforms (joblib#494) [MRG+1] activate coverage on multiple builds (joblib#493) ...
yarikoptic
added a commit
to yarikoptic/joblib
that referenced
this pull request
Nov 3, 2017
* commit '0.11-7-g0d2e765': (60 commits) Add configuration for readthedocs Minor fixes in CHANGES.rst Set relase version to 0.11 Add 0.11 section to changelog Fix rst for correct rendering on PyPI MAINT update release instructions to use twine [MRG] Fix AppVeyor test exit code (joblib#505) [MRG] turn warnings into error in the doc generation (joblib#504) MAINT replace py.test by pytest MAINT remove most warnings from documentating the doc Shorter error message when cache results can not be loaded. (joblib#501) Replace deprecated logging.warn by logging.warning add pypi badge to readme and move the bagdes to the top (joblib#500) Enable codecov on AppVeyor (joblib#497) Improve folder organisation for CI files (joblib#499) Revert flake8 version to 2.5.1 Use Python 3.5 on AppVeyor (joblib#495) Fix race condition in Memory when persisting output in parallel (joblib#491) WindowsError should be a type under non-Windows platforms (joblib#494) [MRG+1] activate coverage on multiple builds (joblib#493) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You could get "TypeError: catching classes that do not inherit from
BaseException is not allowed" when hitting Control-C.