MAINT: rename circleci.yml to be compliant with v2 #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See the documentation for details. |
Codecov Report
@@ Coverage Diff @@
## master #771 +/- ##
==========================================
+ Coverage 95.15% 95.31% +0.15%
==========================================
Files 44 44
Lines 6273 6273
==========================================
+ Hits 5969 5979 +10
+ Misses 304 294 -10
Continue to review full report at Codecov.
|
|
Merged. Thanks for the fix. |
yarikoptic
added a commit
to yarikoptic/joblib
that referenced
this pull request
Oct 28, 2018
* tag '0.12.5': Release 0.12.5 MAINT Loky 2.3.1 and cloudpickle 0.5.6 (joblib#778) Fix ResourceWarning: unclosed file in tests (joblib#775) FIX: convert text element to vector path in svg logo (joblib#773) MAINT: rename circleci.yml to be compliant with v2 (joblib#771) DOC: fix joblib logo fonts style (joblib#772) Back to dev mode
yarikoptic
added a commit
to yarikoptic/joblib
that referenced
this pull request
Oct 28, 2018
* releases: Release 0.12.5 MAINT Loky 2.3.1 and cloudpickle 0.5.6 (joblib#778) Fix ResourceWarning: unclosed file in tests (joblib#775) FIX: convert text element to vector path in svg logo (joblib#773) MAINT: rename circleci.yml to be compliant with v2 (joblib#771) DOC: fix joblib logo fonts style (joblib#772) Back to dev mode Release 0.12.4 Loky 2.3.0 and configuration for PyPy on travis (joblib#769) Fixed bug : loading with corrupted cache with mmap mode (joblib#763) Back to dev mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to circle ci documentation the configuration file should be located in
.circleci/config.yml. Joblib is still using the old version config file.I'm wondering why it still works on master.