Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add surface-of-section methods #560

Merged
merged 18 commits into from Mar 29, 2023
Merged

Add surface-of-section methods #560

merged 18 commits into from Mar 29, 2023

Conversation

jobovy
Copy link
Owner

@jobovy jobovy commented Mar 29, 2023

Adds methods to Orbit objects to efficiently and accurately compute surfaces of section

@jobovy jobovy added this to the v1.9 milestone Mar 29, 2023
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (21dfb93) 99.83% compared to head (9bef72b) 99.83%.

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #560    +/-   ##
========================================
  Coverage   99.83%   99.83%            
========================================
  Files         196      196            
  Lines       28052    28598   +546     
========================================
+ Hits        28005    28551   +546     
  Misses         47       47            
Impacted Files Coverage Δ
galpy/orbit/Orbits.py 99.78% <100.00%> (+0.01%) ⬆️
galpy/orbit/integrateFullOrbit.py 100.00% <100.00%> (ø)
galpy/orbit/integratePlanarOrbit.py 100.00% <100.00%> (ø)
galpy/orbit/orbit_c_ext/integrateFullOrbit.c 100.00% <100.00%> (ø)
galpy/orbit/orbit_c_ext/integratePlanarOrbit.c 100.00% <100.00%> (ø)
galpy/util/bovy_coords.c 100.00% <100.00%> (ø)
galpy/util/conversion.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jobovy jobovy merged commit af1943a into main Mar 29, 2023
56 checks passed
@jobovy jobovy deleted the sos branch March 29, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant