-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPT-1 Use Ubuntu 22.04 LTS in Dockerfile #15
Conversation
1283ba6
to
7c01caa
Compare
Looks good. The wkhtmltopdf should be tested later because in the past we had sometimes problems with wrong layouts etc. But probably not a big deal with the minor update. |
We have some tests failing in the corresponding PR in |
f2e7f48
to
57aac5a
Compare
57aac5a
to
f499475
Compare
80800b9
to
d85d97f
Compare
3295de7
to
bfbf238
Compare
All automated tests are passing: https://github.com/jobrad-gmbh/odoo-addons-jobrad/pull/3070 Manual testing in the sandbox still required: https://erp.cpt-1.dev.jobrad.org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I just had a minor comment.
Changes
ttf-dejavu
package has been renamed tofonts-dejavu
tzdata
package is not installed by default so it is installed manuallywkhtmltopdf
0.12.5
) cannot be installed because it depends on oldlibssl
0.12.6
) which is at the same time the latest version available since the project is not maintained any more22.04 LTS
comes with Python3.10
odoo
dependencies do not compile from Python3.10
onward either because of Cython version changes or Python C API changes3.8
pip --break-system-packages
)python3-magic
was replaced with pip'spython-magic
python3-cairocffi
was replaced with pip'scairocffi
2.03
to1.83
GBFuture notes
ubuntu
user24.04 LTS
image comes withubuntu
user (uid=1000
)ubuntu
user since it is not needed and causes trouble with permissions when mounting sources into a dev containerodoo
user gets to haveuid=1000
wkhtmltopdf
will have to be compiled from source (good luck 馃崁)