Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooling updates: Ruff and Poetry dependency groups #184

Merged
merged 36 commits into from
Mar 11, 2023
Merged

Conversation

jodal
Copy link
Owner

@jodal jodal commented Mar 11, 2023

Poetry dependency groups

Biip now uses poetry dependency groups to only define dependencies once, and then reference the groups of dependencies needed for each nox session.

Ruff linter

Biip has switched out flake8 and isort for ruff, and enabled a whole lot of new linting rules. The total set of changes required to pass the new rules is quite limited, so they match pretty well the existing code style. This will hopefully help maintain that code style over time.

@codecov
Copy link

codecov bot commented Mar 11, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (212cf7e) 100.00% compared to head (e7afcc7) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #184   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          916       912    -4     
  Branches       147       146    -1     
=========================================
- Hits           916       912    -4     
Impacted Files Coverage Δ
src/biip/__init__.py 100.00% <100.00%> (ø)
src/biip/_exceptions.py 100.00% <100.00%> (ø)
src/biip/_parser.py 100.00% <100.00%> (ø)
src/biip/gs1/__init__.py 100.00% <100.00%> (ø)
src/biip/gs1/_element_strings.py 100.00% <100.00%> (ø)
src/biip/gs1/_messages.py 100.00% <100.00%> (ø)
src/biip/gs1/checksums.py 100.00% <100.00%> (ø)
src/biip/gtin/_gtin.py 100.00% <100.00%> (ø)
src/biip/gtin/_rcn.py 100.00% <100.00%> (ø)
src/biip/symbology.py 100.00% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jodal jodal merged commit 059bc69 into main Mar 11, 2023
@jodal jodal deleted the tooling-updates branch March 11, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant