Stop zeroing last digits of RCNs without variable parts #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #97 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 771 784 +13
Branches 109 113 +4
=========================================
+ Hits 771 784 +13
Continue to review full report at Codecov.
|
aksell
reviewed
Sep 8, 2021
| @pytest.mark.parametrize( | ||
| "rcn_region, value", | ||
| [ | ||
| (RcnRegion.NORWAY, "00012348"), |
There was a problem hiding this comment.
why do we expect 00 to be kept untouched? It does not seem like one of the company prefixes
Line 27 in cf45077
There was a problem hiding this comment.
Good catch. It's an RCN-8, which are GTIN-8 with the prefix 0 or 2, which are both Company RCNs. I'll double-check the standard and update the docstring.
jodal
force-pushed
the
fix-rcn-zeroing-nonvariable-numbers
branch
from
1412442
to
31d9bb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.