Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 3.5 support #89

Merged
merged 2 commits into from
Jan 4, 2020
Merged

Remove Python 3.5 support #89

merged 2 commits into from
Jan 4, 2020

Conversation

jodal
Copy link
Owner

@jodal jodal commented Jan 4, 2020

Python 3.5 was released in September 2015, thus it does not reach end-of-life before September 2020.

My main motivation for removing support for Python 3.5 before it reaches end-of-life is to be able to use some of the typing improvements in Python 3.6, e.g. typing.NamedTuple and PEP 526 syntax for variable type annotations.

@jodal jodal self-assigned this Jan 4, 2020
@jodal jodal added this to the v3.0 milestone Jan 4, 2020
@jodal jodal merged commit ca7c901 into develop Jan 4, 2020
@jodal jodal deleted the remove-py35 branch January 4, 2020 18:39
@codecov
Copy link

codecov bot commented Jan 4, 2020

Codecov Report

Merging #89 into develop will increase coverage by 0.18%.
The diff coverage is 94.11%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #89      +/-   ##
===========================================
+ Coverage    94.91%   95.09%   +0.18%     
===========================================
  Files           12       12              
  Lines          551      551              
===========================================
+ Hits           523      524       +1     
+ Misses          28       27       -1
Impacted Files Coverage Δ
pykka/_future.py 100% <ø> (ø) ⬆️
pykka/debug.py 0% <0%> (ø) ⬆️
pykka/_registry.py 100% <100%> (ø) ⬆️
pykka/_proxy.py 98.96% <100%> (ø) ⬆️
pykka/_ref.py 100% <100%> (ø) ⬆️
pykka/_actor.py 95.96% <100%> (+0.8%) ⬆️
pykka/_envelope.py 100% <100%> (ø) ⬆️
pykka/_threading.py 95.65% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e76609...2e5d3ff. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant