Add win32 platform support.
#4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds Windows support to the mill action, using the `--no-server` option since it fails on the Github CI with a similar error message to com-lihaoyi/mill#675.
Comment on lines
+10
to
+20
| strategy: | ||
| matrix: | ||
| include: | ||
| - name: Windows | ||
| os: windows-latest | ||
| mill: 'mill --no-server' | ||
| - name: Linux | ||
| os: ubuntu-latest | ||
| mill: 'mill' | ||
| name: ${{ matrix.name }} | ||
| runs-on: ${{ matrix.os }} |
There was a problem hiding this comment.
I think it could be good to check the action runs for both Windows and Linux images, but mill --no-server shouldn't be required now (see com-lihaoyi/mill#781 (comment))
Suggested change
| strategy: | |
| matrix: | |
| include: | |
| - name: Windows | |
| os: windows-latest | |
| mill: 'mill --no-server' | |
| - name: Linux | |
| os: ubuntu-latest | |
| mill: 'mill' | |
| name: ${{ matrix.name }} | |
| runs-on: ${{ matrix.os }} | |
| strategy: | |
| matrix: | |
| include: | |
| - name: Windows | |
| os: windows-latest | |
| - name: Linux | |
| os: ubuntu-latest | |
| name: ${{ matrix.name }} | |
| runs-on: ${{ matrix.os }} |
There was a problem hiding this comment.
Sure that sounds good. I don't think this will be merged anytime soon though - this PR has been outstanding for years.
| steps: | ||
| - uses: actions/checkout@v1 | ||
| - uses: ./ | ||
| name: "Set up Mill" | ||
| with: | ||
| mill-version: 0.8.0 | ||
| - name: "Run Mill" | ||
| run: mill version | ||
| run: ${{ matrix.mill }} version |
There was a problem hiding this comment.
Suggested change
| run: ${{ matrix.mill }} version | |
| run: mill version |
see above comment
|
@jodersky what do you think of checking it works for Ubuntu/Mac/Windows? Even if people use mill to make jars that are cross platform, they might have a preference for doing it on a given OS in GitHub Actions. We'd need to add Mac to the OS matrix to finish that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Windows support to the mill action, using the
--no-serveroption since it fails on the Github CI with a similar error message
to com-lihaoyi/mill#675.